|WARNING| pw169251 [PATCH v2 16/19] net/i40e: reimplement FDIR parser

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/169251

_coding style issues_


WARNING:LONG_LINE_COMMENT: line length of 101 exceeds 100 columns
#2961: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:48:
+ * Pattern: START -> ETH -> [VLAN] -> (IPv4 | IPv6) -> [TCP | UDP | SCTP | ESP | L2TPv3 | GTP] -> END

WARNING:LONG_LINE: line length of 125 exceeds 100 columns
#3395: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:482:
+		memcpy(&fdir_filter->input.flow.ipv6_flow.src_ip, &ipv6_spec->hdr.src_addr, sizeof(ipv6_spec->hdr.src_addr));

WARNING:LONG_LINE: line length of 125 exceeds 100 columns
#3399: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:486:
+		memcpy(&fdir_filter->input.flow.ipv6_flow.dst_ip, &ipv6_spec->hdr.dst_addr, sizeof(ipv6_spec->hdr.dst_addr));

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#3480: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:567:
+	if (fdir_filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV4) {
[...]
+	} else if (fdir_filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV6) {
[...]

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#3567: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:654:
+	if (fdir_filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV4) {
[...]
+	} else if (fdir_filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV6) {
[...]

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#3658: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:745:
+	if (fdir_filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV4) {
[...]
+	} else if (fdir_filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV6) {
[...]

WARNING:BRACES: braces {} are not necessary for single statement blocks
#3667: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:754:
+	if (!CI_FIELD_IS_ZERO(&sctp_mask->hdr.tag)) {
+		fdir_filter->input.flow_ext.input_set |= I40E_INSET_SCTP_VT;
+	}

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#3940: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1027:
+		if (is_udp)
[...]
+		else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#3942: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1029:
+		else {

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#3946: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1033:
+		if (is_udp)
[...]
+		else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#3948: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1035:
+		else {

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#3970: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1057:
+
+}

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#3986: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1073:
+	if (fdir_filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV4) {
[...]
+	} else if (fdir_filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV6) {
[...]

WARNING:BRACES: braces {} are not necessary for single statement blocks
#4504: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1591:
+	if (ret) {
+		return ret;
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#4509: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1596:
+	if (ret) {
+		return ret;
+	}

CHECK:BOOL_COMPARISON: Using comparison to false is error prone
#4779: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1866:
+	needs_wait = fdir_flow->installed == false &&

total: 0 errors, 12 warnings, 4 checks, 4800 lines checked