|WARNING| usertools/telemetry-watcher: fix hang on startup

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/169309

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-09

# Review of series.patch

## Summary

This patch fixes a hang in `dpdk-telemetry-watcher` by making an informational message print only in interactive mode. The fix is correct, but there is one style issue to address.

---

## Errors

None.

---

## Warnings

### 1. Implicit comparison in conditional (C style applied to Python)

**File:** `usertools/dpdk-telemetry.py`  
**Line:** `if os.isatty(sys.stdin.fileno()):`

**Issue:** While this is Python code (not C), DPDK C coding standards require explicit comparisons for clarity. The equivalent Python style would be more explicit.

**Current code:**
```python
if os.isatty(sys.stdin.fileno()):
```

**Suggested:**
```python
if os.isatty(sys.stdin.fileno()) is True:
```

or more idiomatically in Python:
```python
if os.isatty(sys.stdin.fileno()) == True:
```

**Note:** This is a minor style suggestion. Python conventions typically prefer the implicit truthiness check (`if condition:`), but for consistency with DPDK's explicit comparison philosophy, an explicit comparison would be more aligned with project standards. However, since this is Python code and not C, this may be acceptable as-is.

---

## Info

### Correctness verification

The fix correctly addresses the root cause:
- The wrapper script expects specific output format
- The new informational message breaks that expectation
- Checking `isatty()` properly distinguishes interactive from scripted use
- The message is correctly sent to stdout (not stderr) only when interactive

### Testing considerations

The patch should be tested with:
1. Interactive telemetry script usage (message should appear)
2. `dpdk-telemetry-watcher` wrapper script (should no longer hang)
3. Non-interactive piped usage (message should not appear)

---

## Overall Assessment

The patch is functionally correct and solves the reported issue. The only minor concern is the implicit truthiness check in the conditional, which could be made explicit for consistency with DPDK coding philosophy (though this is Python, not C, so standard Python idioms may take precedence).