|WARNING| net/txgbe: fix FDIR devarg integer width

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/169317

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-09

# DPDK Patch Review

## Patch Summary
This patch fixes a buffer overwrite bug in the txgbe driver where a u16 value was being written into a u8 variable, causing adjacent memory corruption.

---

## ERRORS

**1. Insufficient bounds checking on devarg values (Error)**

The patch widens `pballoc` and `drop_queue` from `u8` to `u16` to match the parsing type, but does NOT add validation that the parsed values fit the hardware constraints. If the hardware expects 8-bit values but now accepts 16-bit input, an out-of-range devarg could cause incorrect hardware programming or silent truncation.

**Suggested fix:** Add bounds checking after parsing:

```c
if (pballoc > UINT8_MAX) {
	PMD_INIT_LOG(ERR, "pballoc value %u exceeds maximum %u",
		     pballoc, UINT8_MAX);
	return -EINVAL;
}
if (drop_queue > UINT8_MAX) {
	PMD_INIT_LOG(ERR, "drop_queue value %u exceeds maximum %u",
		     drop_queue, UINT8_MAX);
	return -EINVAL;
}
```

(Or use the actual hardware maximum if it is less than 255. For example, if `drop_queue` hardware field is 7 bits, validate `<= 127` instead of `<= UINT8_MAX`.)

---

## WARNINGS

None.

---

## INFO

**1. Patch addresses a real correctness bug**

The original code had a serious buffer overwrite:
- `txgbe_handle_devarg()` stores a `uint16_t` through the pointer passed to `extra_args`
- When `pballoc` (u8) was the target, writing a u16 clobbered the adjacent `drop_queue` byte
- This caused the default value `drop_queue = 127` to be overwritten when the user set `pkt-filter-size`

Widening both fields to `u16` eliminates the overwrite, which is correct.

---

## SUMMARY

The patch correctly fixes the buffer overwrite by matching the variable width to the parsing type. However, it introduces a potential new issue: values beyond the hardware's 8-bit capacity could now be accepted without error. Add validation after parsing to ensure devarg values remain within hardware limits.