|WARNING| pw169396 [PATCH v2 31/47] drivers: rework dpaa2 Tx confirmation

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/169396

_coding style issues_


CHECK:SPACING: No space is necessary after a cast
#348: FILE: drivers/net/dpaa2/dpaa2_ethdev.h:510:
+	RTE_ATOMIC(uint64_t) rx_timestamp;

CHECK:SPACING: No space is necessary after a cast
#351: FILE: drivers/net/dpaa2/dpaa2_ethdev.h:512:
+	RTE_ATOMIC(uint64_t) tx_timestamp;

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#360: FILE: drivers/net/dpaa2/dpaa2_ethdev.h:519:
+	struct dpaa2_queue * RTE_ATOMIC(next_txq_to_cnf);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'next_txq_to_cnf' should also have an identifier name
#360: FILE: drivers/net/dpaa2/dpaa2_ethdev.h:519:
+	struct dpaa2_queue * RTE_ATOMIC(next_txq_to_cnf);

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_mbuf' - possible side-effects?
#421: FILE: drivers/net/dpaa2/dpaa2_rxtx.c:78:
+#define DPAA2_MBUF_TO_CONF_CONTIG_FD(_mbuf, _fd)  do { \
+	DPAA2_SET_FD_ADDR(_fd, DPAA2_MBUF_VADDR_TO_IOVA(_mbuf)); \
+	DPAA2_SET_FD_LEN(_fd, (_mbuf)->data_len); \
+	DPAA2_SET_ONLY_FD_BPID(_fd, MAX_BPID); \
+	DPAA2_SET_FD_IVP(_fd); \
+	DPAA2_SET_FD_OFFSET(_fd, (_mbuf)->data_off); \
+	DPAA2_SET_FD_FRC(_fd, 0); \
+	DPAA2_RESET_FD_CTRL(_fd); \
+	DPAA2_SET_FD_FLC(_fd, _mbuf); \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_fd' - possible side-effects?
#421: FILE: drivers/net/dpaa2/dpaa2_rxtx.c:78:
+#define DPAA2_MBUF_TO_CONF_CONTIG_FD(_mbuf, _fd)  do { \
+	DPAA2_SET_FD_ADDR(_fd, DPAA2_MBUF_VADDR_TO_IOVA(_mbuf)); \
+	DPAA2_SET_FD_LEN(_fd, (_mbuf)->data_len); \
+	DPAA2_SET_ONLY_FD_BPID(_fd, MAX_BPID); \
+	DPAA2_SET_FD_IVP(_fd); \
+	DPAA2_SET_FD_OFFSET(_fd, (_mbuf)->data_off); \
+	DPAA2_SET_FD_FRC(_fd, 0); \
+	DPAA2_RESET_FD_CTRL(_fd); \
+	DPAA2_SET_FD_FLC(_fd, _mbuf); \
+} while (0)

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mbuf->data_off > RTE_ALIGN(sg_size + offset, 8)'
#740: FILE: drivers/net/dpaa2/dpaa2_rxtx.c:716:
+	if (mbuf->pool->ops_index == hw_mp->ops_index &&
+		RTE_MBUF_DIRECT(mbuf) &&
+		(mbuf->data_off > RTE_ALIGN(sg_size + offset, 8))) {

CHECK:BOOL_COMPARISON: Using comparison to true is error prone
#1275: FILE: drivers/net/dpaa2/dpaa2_rxtx.c:1531:
+		if (bulk_free == true &&

total: 1 errors, 1 warnings, 6 checks, 2044 lines checked