|WARNING| [2/2] event/cnxk: advertise CN20K preschedule capabilities

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/169414

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-10

# DPDK Patch Review

## Patch 1/2: eventdev: fix vector adapter power-of-2 size check

### Errors

**Logic error in conditional test (inverted condition)**

The original code rejected valid power-of-2 sizes and accepted invalid non-power-of-2 sizes. The patch correctly inverts the condition.

**Original (wrong):**
```c
if (info->log2_sz && rte_is_power_of_2(conf->vector_sz) != 0) {
```

**Fixed:**
```c
if (info->log2_sz && rte_is_power_of_2(conf->vector_sz) == 0) {
```

This is correct. `rte_is_power_of_2()` returns non-zero (true) when the value IS a power of 2, so the condition should trigger the error when it returns 0 (false), meaning NOT a power of 2.

### Warnings

None.

### Info

None.

---

## Patch 2/2: event/cnxk: advertise CN20K preschedule capabilities

### Errors

**Statistics accumulation using `|=` on capability flags**

The patch adds capability flags using `|=` which is correct for bitmask accumulation. However, reviewing the context shows this is initializing `dev_info->event_dev_cap`, not accumulating into an existing running total.

Looking at the code flow: `cnxk_sso_info_get(dev, dev_info)` is called first (line 432), which likely initializes `dev_info->event_dev_cap` with base capabilities, then this patch adds additional CN20K-specific capabilities.

This pattern is acceptable - the `|=` correctly adds new bits to the existing capability mask set by the common function.

### Warnings

None.

### Info

None.

---

## Overall Assessment

Both patches are bug fixes that correct logic errors:

1. **Patch 1/2** fixes a critical validation bug where the power-of-2 check was inverted, causing valid configurations to be rejected and invalid ones to be accepted.

2. **Patch 2/2** correctly advertises preschedule capabilities that were implemented but never exposed, making the feature discoverable to applications.

The patches follow DPDK coding standards, have appropriate `Fixes:` tags and `Cc: stable at dpdk.org`, and address real correctness issues. No style violations, forbidden tokens, or resource management issues detected.