|WARNING| [2/2] net/ice: disable link negotiation for fixed speed selection

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/169416

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-10

# DPDK Patch Review

## Patch 1/2: net/ice: check for missing fixed speed setting

### Errors

None.

### Warnings

None.

### Info

**Missing release notes update**
A user-visible behavior change (new error returned for invalid configuration) requires a release note entry.
Add an item to the "Driver" or "Bugfixes" section in `doc/guides/rel_notes/release_26_11.rst`.

---

## Patch 2/2: net/ice: disable link negotiation for fixed speed selection

### Errors

**Variable declaration at point of use (C99 style) mixed with block-start declarations**
```c
bool link_autoneg = (conf->link_speeds & RTE_ETH_LINK_SPEED_FIXED) == 0;
return ice_phy_conf_link(hw, speed, true, link_autoneg);
```
This mixes C99 declaration-at-use with the existing block-start style in the function.
For consistency with the existing code pattern in `ice_apply_link_speed()`,
declare the variable at the start of its scope.
```c
bool link_autoneg;

/* ... existing code ... */

link_autoneg = (conf->link_speeds & RTE_ETH_LINK_SPEED_FIXED) == 0;
return ice_phy_conf_link(hw, speed, true, link_autoneg);
```

**Missing explicit comparison**
```c
bool link_autoneg = (conf->link_speeds & RTE_ETH_LINK_SPEED_FIXED) == 0;
```
DPDK style requires explicit comparison against 0 on integer expressions, not implicit truthiness.
The current code inverts a comparison to 0, which is acceptable for the outer comparison,
but the pattern is clearer when written without the double negation:
```c
bool link_autoneg = (conf->link_speeds & RTE_ETH_LINK_SPEED_FIXED) != 0 ? false : true;
```
Or more simply:
```c
bool link_autoneg = !(conf->link_speeds & RTE_ETH_LINK_SPEED_FIXED);
```
Note: On `bool` types, direct truthiness without comparison is acceptable per DPDK guidelines,
so if you prefer the negation form, the final assignment is fine as-is.
However, the bitmask test itself should be made more explicit.

### Warnings

**Missing release notes update**
A user-visible behavior change (link autonegotiation disabled for fixed-speed configuration) requires a release note entry.
Add an item to the "Driver" or "Bugfixes" section in `doc/guides/rel_notes/release_26_11.rst`.

### Info

None.

---

## Summary

Both patches are correct from a functionality standpoint (no resource leaks, use-after-free, or logic errors).
The main issues are:
- C99 mixed declaration style inconsistency (Error)
- Implicit truthiness on bitmask test (Error - style requirement)
- Missing release notes for user-visible changes (Warning)