|SUCCESS| [v1,1/1] net/iavf: fix memory leak on IPsec SP delete

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/169520

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-14

# DPDK Patch Review: net/iavf: fix memory leak on IPsec SP delete

## Summary
This patch fixes a resource leak in the iavf IPsec driver by preventing an early return that skipped cleanup of allocated buffers. The fix is correct and addresses a real bug.

---

## Correctness Issues

###  No Issues Found

The patch correctly fixes a resource leak. The original code performed an early `return` that bypassed the cleanup code at the `update_cleanup` label, leaking both `request` and `response` buffers. Changing the early return to assign `rc` and fall through to cleanup is the correct fix.

**Verification of the fix:**
- Both error path (`rc = -EFAULT`) and success path now reach `update_cleanup`
- The `free(request)` and implied `free(response)` (assuming present in subsequent lines) will execute in both cases
- The return value is preserved via the `rc` variable

---

## Code Style

###  No Issues Found

The change is minimal and maintains consistency with the existing code style:
- The assignment `rc = response->ipsec_data.ipsec_status->status;` matches the pattern used in the error path
- Indentation and formatting are consistent with surrounding code

---

## API and Documentation

###  No Release Notes Required

This is a bug fix in an internal driver function (`iavf_ipsec_crypto_security_policy_delete`), not a public API change. The patch correctly includes:
- `Fixes:` tag referencing the original commit
- `Cc: stable at dpdk.org` for backporting to stable releases

Release notes are not required for driver-internal bug fixes.

---

## Process Compliance

###  Compliant

- Commit message follows DPDK format
- Appropriate tags present (`Fixes:`, `Cc: stable at dpdk.org`, `Signed-off-by:`)
- Single logical change (fixes one specific bug)

---

## Final Assessment

**APPROVED** - This patch correctly fixes a resource leak with no additional issues identified.

The fix is minimal, correct, and appropriately tagged for stable backporting. No further changes needed.