|WARNING| net/ice: ignore WRED parameters for tail drop in DCF

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/169527

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-14

# DPDK Patch Review

## Summary
Patch simplifies WRED parameter validation in ICE DCF traffic management by only rejecting unsupported congestion management modes rather than validating unused WRED parameters when tail drop is configured.

---

## Errors

None identified.

---

## Warnings

### 1. Misleading error message for valid enum value

**Location:** `ice_dcf_sched.c:203`

The condition `params->leaf.cman != RTE_TM_CMAN_TAIL_DROP` will trigger when `cman` is `RTE_TM_CMAN_WRED` (a valid enum member that the driver doesn't support) but will also trigger when `cman == 0` (which equals `RTE_TM_CMAN_TAIL_DROP` per the API definition in `rte_tm.h`).

The error message "Only tail drop is supported" is correct for the WRED case but may be confusing if other enum values are added in future API versions.

**Suggested improvement:**

```c
/* Verify tail drop mode - reject WRED and any future modes */
if (params->leaf.cman != RTE_TM_CMAN_TAIL_DROP) {
	error->type = RTE_TM_ERROR_TYPE_NODE_PARAMS_CMAN;
	error->message = "Only RTE_TM_CMAN_TAIL_DROP is supported";
	return -EINVAL;
}
```

### 2. Missing release notes update

The patch fixes a bug where valid tail-drop configurations were incorrectly rejected. This is a functional correction affecting application behavior and should be documented in the release notes.

**Action:** Add an entry to `doc/guides/rel_notes/release_26_11.rst` (or the appropriate current release file) under "Fixed Issues" describing that tail-drop nodes no longer require explicit `RTE_TM_WRED_PROFILE_ID_NONE`.

---

## Info

### Code simplification achieves stated goal

The patch correctly addresses the issue: when `cman` is `RTE_TM_CMAN_TAIL_DROP` (value 0), the WRED profile and shared context fields are unused and need not be validated. The removal of four separate WRED-specific checks is appropriate and simplifies the code.

### Comparison style

The explicit comparison `!= RTE_TM_CMAN_TAIL_DROP` is acceptable here since it's comparing against a named constant rather than testing truthiness. The DPDK style guidelines require explicit comparisons against 0/NULL but permit comparisons against named enum constants.

---

## Conclusion

The patch is functionally correct and improves code clarity. Address the missing release notes (Warning priority). Consider the minor error message refinement (low priority).