|WARNING| net/mana: fix Tx stall from send queue free-space unit mismatch

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/169521

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-15

# DPDK Patch Review: net/mana: fix Tx stall from send queue free-space unit mismatch

## Summary
This patch fixes a unit mismatch bug in the MANA driver's send queue capacity calculation that caused premature -EBUSY returns and Tx stalls.

---

## Correctness Issues

### None Found

The patch correctly identifies and fixes a unit mismatch bug:
- **Before**: `queue->count - (queue->head - queue->tail)` mixed entry count with WQE unit count
- **After**: `(queue->size / GDMA_WQE_ALIGNMENT_UNIT_SIZE) - (queue->head - queue->tail)` uses consistent units

The fix:
- Uses `queue->size` (total queue size in bytes) divided by `GDMA_WQE_ALIGNMENT_UNIT_SIZE` to get capacity in the same units as `head` and `tail`
- Matches the unit system used by `gdma_get_wqe_pointer()` for ring wrapping
- Correctly notes that Rx is unaffected because its WQEs are exactly one unit in size

Error path analysis: The change only affects the capacity check; no new error paths or resource management changes are introduced.

---

## Style and Formatting

### Errors

**Multi-line comment style violation**
The added comment does not follow DPDK multi-line comment formatting:
```c
/* head/tail count WQE alignment units, so the capacity they are compared
 * against must too: queue->count is in entries and undercounts the
 * queue, stalling Tx well below capacity.
 */
```

Should be formatted with proper alignment:
```c
/*
 * head/tail count WQE alignment units, so the capacity they are compared
 * against must too: queue->count is in entries and undercounts the
 * queue, stalling Tx well below capacity.
 */
```

### Warnings

**Line length**
The comment line wrapping could be improved for readability. While the current formatting is acceptable, consider rewording to avoid the awkward mid-sentence break at "compared". For example:
```c
/*
 * head/tail count WQE alignment units. The capacity must use the same
 * units: queue->count is in entries and undercounts the queue,
 * stalling Tx well below capacity.
 */
```

---

## Documentation and Testing

### Info

**Release notes**: This is a bug fix for existing functionality. The commit message clearly explains the impact (Tx stall at 1/8th queue capacity), which is sufficient. No release notes entry is strictly required for driver bug fixes, but could be added if this affects users of the MANA driver in production.

**Testing note**: The patch comment indicates this is independent of other pending patches. Consider adding a note in the commit message about how the fix was verified (e.g., "Verified with workload that previously triggered stalls").

---

## Review Summary

**Errors**: 1 (comment formatting)
**Warnings**: 1 (comment wording/wrapping)
**Info**: 1 (testing/release notes consideration)

The core bug fix is correct and addresses a real capacity calculation error. The only required change is fixing the multi-line comment style to comply with DPDK formatting standards.