|WARNING| net/ice: remove unreachable DCF scheduler branch

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/169522

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-15

# DPDK Patch Review

## Patch Summary
This patch removes unreachable code in the ICE DCF scheduler validation logic. The dead code checked for WFQ weight mode after an earlier check already guaranteed it would be NULL.

---

## Findings

### Errors

None found.

### Warnings

**1. Typo in removed error message**

The removed error message says "WFP should be byte mode" but likely meant "WFQ should be byte mode" (WFQ = Weighted Fair Queuing, not WFP).

While this code is being removed, it's worth noting for the commit message or if similar error messages exist elsewhere in the codebase.

### Info

**1. Consider verifying the logic chain**

The patch description states that `wfq_weight_mode` is guaranteed to be NULL after the earlier validation at line 180-185 (visible in context). To confirm this reasoning is sound:

The earlier check at line 180-185 validates:
```c
if (params->nonleaf.wfq_weight_mode) {
    error->type = RTE_TM_ERROR_TYPE_NODE_PARAMS_WFQ_WEIGHT_MODE;
    error->message = "WFQ not supported";
    return -EINVAL;
}
```

This rejects if `wfq_weight_mode` is non-NULL (truthy). Therefore, execution continues only if `wfq_weight_mode` is NULL or 0.

The removed code checked:
```c
} else if (params->nonleaf.wfq_weight_mode &&
           !(*params->nonleaf.wfq_weight_mode)) {
```

For this condition to be true, `wfq_weight_mode` must be:
1. Non-NULL (to pass the first part of the `&&`)
2. Pointing to a zero value (to satisfy `!(*params->nonleaf.wfq_weight_mode)`)

But case (1) is already rejected by the earlier check. The reasoning is correct -- this branch is indeed unreachable.

**2. Test coverage**

Since this removes dead code rather than changing behavior, existing tests should continue to pass without modification. However, if there were tests specifically exercising this error path (expecting the "WFP should be byte mode" message), those tests would also be dead code and should be removed.

---

## Summary

The patch correctly removes unreachable code. The logic analysis is sound: the earlier check rejects any non-NULL `wfq_weight_mode`, making the later check for `wfq_weight_mode && !(*wfq_weight_mode)` impossible to reach.

**Action Items:**
- Warning: Note the typo "WFP" (should be "WFQ") existed in the removed message
- Info: Verify no tests rely on the removed error message

The patch is correct and improves code clarity by removing an impossible validation path.