|WARNING| net/bnxt: use enum value for interface type check

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/169575

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-15

# DPDK Patch Review

## Patch Summary
The patch changes the interface type check in `ulp_rte_port_act_handler()` from `if (!intf_type)` to `if (intf_type == BNXT_ULP_INTF_TYPE_INVALID)`.

---

## Findings

### Errors

**1. Implicit comparison on enum value**

The original code `if (!intf_type)` is an implicit truthiness check on an enum value. DPDK coding standards require explicit comparison against the specific value being tested. The patch correctly changes this to `if (intf_type == BNXT_ULP_INTF_TYPE_INVALID)`.

However, the patch description claims this is about "avoiding relying on the numeric value" -- this is correct, but the DPDK guideline frame is: explicit comparison makes the code clearer and matches DPDK style for non-boolean types.

This is a **correctness improvement** because it makes the intent explicit and doesn't rely on the enum's numeric assignment.

---

### Warnings

None.

---

### Info

**1. Commit message could reference coding guidelines**

The commit message correctly explains the change but could optionally reference that DPDK coding standards require explicit comparisons for non-boolean types. The current justification ("makes the code clearer") is sufficient but a reference to the style guide would strengthen it.

However, since the existing message is clear and accurate, this is optional rather than required.

---

## Summary

The patch is **correct and should be accepted**. It fixes a violation of DPDK coding style by replacing an implicit truthiness check with an explicit enum comparison. The change improves code clarity and eliminates reliance on the numeric value of `BNXT_ULP_INTF_TYPE_INVALID`.

No blocking issues found.