|WARNING| pw169688 [PATCH v3 18/19] net/i40e: reimplement hash parser

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/169688

_coding style issues_


WARNING:BRACES: braces {} are not necessary for any arm of this statement
#929: FILE: drivers/net/intel/i40e/i40e_flow_hash.c:288:
+	if (udp) {
[...]
+	} else {
[...]

WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#930: FILE: drivers/net/intel/i40e/i40e_flow_hash.c:289:
+		hash_ctx->pctype = ipv4 ? I40E_CUSTOMIZED_ESP_IPV4_UDP : I40E_CUSTOMIZED_ESP_IPV6_UDP;

WARNING:LONG_LINE: line length of 115 exceeds 100 columns
#1550: FILE: drivers/net/intel/i40e/i40e_flow_hash.c:909:
+		{I40E_FILTER_PCTYPE_NONF_IPV4_OTHER, RTE_ETH_RSS_NONFRAG_IPV4_OTHER | I40E_HASH_IPV4_L23_RSS_MASK},

WARNING:LONG_LINE: line length of 115 exceeds 100 columns
#1551: FILE: drivers/net/intel/i40e/i40e_flow_hash.c:910:
+		{I40E_FILTER_PCTYPE_NONF_IPV6_OTHER, RTE_ETH_RSS_NONFRAG_IPV6_OTHER | I40E_HASH_IPV6_L23_RSS_MASK},

WARNING:LONG_LINE: line length of 112 exceeds 100 columns
#1556: FILE: drivers/net/intel/i40e/i40e_flow_hash.c:915:
+		{I40E_FILTER_PCTYPE_NONF_IPV4_TCP, RTE_ETH_RSS_NONFRAG_IPV4_TCP | I40E_HASH_IPV4_L234_RSS_MASK},

WARNING:LONG_LINE: line length of 112 exceeds 100 columns
#1557: FILE: drivers/net/intel/i40e/i40e_flow_hash.c:916:
+		{I40E_FILTER_PCTYPE_NONF_IPV6_TCP, RTE_ETH_RSS_NONFRAG_IPV6_TCP | I40E_HASH_IPV6_L234_RSS_MASK},

WARNING:LONG_LINE: line length of 112 exceeds 100 columns
#1559: FILE: drivers/net/intel/i40e/i40e_flow_hash.c:918:
+		{I40E_FILTER_PCTYPE_NONF_IPV4_UDP, RTE_ETH_RSS_NONFRAG_IPV4_UDP | I40E_HASH_IPV4_L234_RSS_MASK},

WARNING:LONG_LINE: line length of 112 exceeds 100 columns
#1560: FILE: drivers/net/intel/i40e/i40e_flow_hash.c:919:
+		{I40E_FILTER_PCTYPE_NONF_IPV6_UDP, RTE_ETH_RSS_NONFRAG_IPV6_UDP | I40E_HASH_IPV6_L234_RSS_MASK},

WARNING:LONG_LINE: line length of 114 exceeds 100 columns
#1562: FILE: drivers/net/intel/i40e/i40e_flow_hash.c:921:
+		{I40E_FILTER_PCTYPE_NONF_IPV4_SCTP, RTE_ETH_RSS_NONFRAG_IPV4_SCTP | I40E_HASH_IPV4_L234_RSS_MASK},

WARNING:LONG_LINE: line length of 114 exceeds 100 columns
#1563: FILE: drivers/net/intel/i40e/i40e_flow_hash.c:922:
+		{I40E_FILTER_PCTYPE_NONF_IPV6_SCTP, RTE_ETH_RSS_NONFRAG_IPV6_SCTP | I40E_HASH_IPV6_L234_RSS_MASK},

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#1616: FILE: drivers/net/intel/i40e/i40e_flow_hash.c:975:
+			return i40e_hash_translate_gtp_inset(&hash_ctx->rss_conf, error);
+		} else {

total: 0 errors, 11 warnings, 0 checks, 3212 lines checked