|WARNING| net/intel: use rte_validate_tx_offload function correctly for i40e/iavf/ice drivers

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/169704

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-16

# DPDK Patch Review

## Summary

This patch corrects a logic error in three Intel network drivers (i40e, iavf, ice) where the return value of `rte_validate_tx_offload()` is misinterpreted. The function returns 0 on success, but the drivers treat non-zero as success, causing valid packets to be dropped when mbuf offload checking is enabled.

## Detailed Review

### Errors

None identified. The fix is correct.

### Warnings

**Missing release notes** (Warning)

This is a bug fix that changes behavior visible to users -- valid packets will no longer be dropped when offload checking is enabled. The fix should be documented in the release notes under `doc/guides/rel_notes/release_26_03.rst` (assuming this targets DPDK 26.03) in the "Fixed Issues" section.

Suggested addition:
```rst
* **Fixed packet drops in Intel drivers with offload checking.**

  Fixed i40e, iavf, and ice drivers incorrectly dropping valid packets when
  EAL offload checking is enabled (``mbuf_check=offload`` device argument).
  The drivers were inverting the success/failure return value of
  ``rte_validate_tx_offload()``.
```

**Missing Fixes tag and Cc: stable** (Warning)

This is a bug fix. It should include:
- A `Fixes:` tag identifying the commit that introduced the inverted logic
- `Cc: stable at dpdk.org` to indicate it should be backported to stable branches

The commit message should include:
```
Fixes: <commit-hash> ("<commit title>")
Cc: stable at dpdk.org
```

To find the original commit, run:
```bash
git log -p --all -S'!rte_validate_tx_offload' -- drivers/net/intel/i40e/i40e_rxtx.c
```
(and similarly for iavf and ice)

### Info

**Code correctness verified**

The fix is correct. `rte_validate_tx_offload()` returns:
- `0` on success (offload configuration is valid)
- `-EINVAL` on error (offload configuration is invalid)

The original code `if (!rte_validate_tx_offload(mb))` evaluates to true when the function returns 0 (success), causing the driver to treat success as an error and drop the packet.

The corrected code `if (rte_validate_tx_offload(mb) != 0)` properly treats non-zero return values as errors.

**Consistent fix across drivers**

The patch applies the same fix to all three affected drivers, which is good for consistency.

---

## Actions Required

1. Add a release notes entry documenting the fix
2. Add `Fixes:` tag(s) identifying the commit(s) that introduced the bug
3. Add `Cc: stable at dpdk.org` for backporting to stable releases