|SUCCESS| [v2] net/mana: fix Tx stall from send queue free-space unit mismatch

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/169706

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-17

# DPDK Patch Review

## Summary

This patch fixes a critical correctness bug in the MANA driver's send queue accounting. The review finds the fix correct and well-implemented, with only one minor documentation suggestion.

---

## Findings

### **Info** - Documentation Enhancement

**Comment style preference**

The new multi-line comment uses C++-style `//` continuation on the second line of what should be a single multi-line C-style comment block:

```c
/* head and tail are in WQE alignment units, so the capacity must
 * come from the queue size in bytes, not the entry count.
 */
```

**Suggestion:**

While the patch correctly uses `/* ... */`, the standard DPDK multi-line comment format would be:

```c
/*
 * head and tail are in WQE alignment units, so the capacity must
 * come from the queue size in bytes, not the entry count.
 */
```

However, the current format is acceptable and commonly used in DPDK for short multi-line comments, so this is purely a minor style preference, not a requirement.

---

## Overall Assessment

**No errors or warnings found.**

The patch correctly addresses a unit mismatch bug that caused premature -EBUSY returns on the Tx path. The fix is sound:

1. **Correctness**: The capacity calculation now correctly divides `queue->size` (bytes) by `GDMA_WQE_ALIGNMENT_UNIT_SIZE` to get units, matching the unit space of `queue->head` and `queue->tail`.

2. **Debug improvement**: The updated `DP_LOG` now reports `queue->size` and `queue_free_units` instead of the now-unused `queue->count`, providing more useful debugging information.

3. **Comment clarity**: The added comment clearly explains why the size-based calculation is necessary, stating the invariant that head/tail are in WQE units.

4. **No resource safety issues**: The change is purely arithmetic and does not introduce leaks, races, or other correctness bugs.

The patch is ready for merge with only the optional minor style note above.