|WARNING| pw169754 [PATCH 2/6] eal: add rte_queue.h with full set of list macros

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Sep 17 19:24:10 CEST 2026

Previous message (by thread): |SUCCESS| pw169756 [PATCH 3/6] build: use rte_queue.h instead of sys/queue.h
Next message (by thread): |Smoke |SUCCESS| pw(169752) sid(39322) job(PER_PATCH_BUILD20196-20260918000723) [v3] examples: add Wycheproof validation app
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/169754

_coding style issues_


WARNING:TYPO_SPELLING: 'musl' may be misspelled - perhaps 'must'?
#92: 
a subset (notably none of the _FOREACH_SAFE variants), and musl has no
                                                           ^^^^

WARNING:TYPO_SPELLING: 'musl' may be misspelled - perhaps 'must'?
#172: FILE: lib/eal/include/rte_queue.h:11:
+ * _FOREACH_SAFE), musl has no such header at all and on Alpine it comes from
                    ^^^^

WARNING:MACRO_ARG_UNUSED: Argument 'head' is not used in function-like macro
#308: FILE: lib/eal/include/rte_queue.h:147:
+#define	SLIST_HEAD_INITIALIZER(head)					\
+	{ NULL }

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#326: FILE: lib/eal/include/rte_queue.h:165:
+	QUEUE_TYPEOF(type) *curelm = SLIST_FIRST(head1);		\
 	                   ^

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#328: FILE: lib/eal/include/rte_queue.h:167:
+		if ((SLIST_FIRST(head1) = SLIST_FIRST(head2)) != NULL)	\

WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#367: FILE: lib/eal/include/rte_queue.h:206:
+#define	SLIST_INIT(head) do {						\
+	SLIST_FIRST((head)) = NULL;					\
+} while (0)

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#388: FILE: lib/eal/include/rte_queue.h:227:
+		QUEUE_TYPEOF(type) *curelm = SLIST_FIRST(head);		\
 		                   ^

WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#395: FILE: lib/eal/include/rte_queue.h:234:
+#define SLIST_REMOVE_AFTER(elm, field) do {				\
+	SLIST_NEXT(elm, field) =					\
+	    SLIST_NEXT(SLIST_NEXT(elm, field), field);			\
+} while (0)

WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#400: FILE: lib/eal/include/rte_queue.h:239:
+#define	SLIST_REMOVE_HEAD(head, field) do {				\
+	SLIST_FIRST((head)) = SLIST_NEXT(SLIST_FIRST((head)), field);	\
+} while (0)

WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#404: FILE: lib/eal/include/rte_queue.h:243:
+#define	SLIST_REMOVE_PREVPTR(prevp, elm, field) do {			\
+	*(prevp) = SLIST_NEXT(elm, field);				\
+} while (0)

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#409: FILE: lib/eal/include/rte_queue.h:248:
+	QUEUE_TYPEOF(type) *swap_first = SLIST_FIRST(head1);		\
 	                   ^

ERROR:SPACING: space required before the open parenthesis '('
#458: FILE: lib/eal/include/rte_queue.h:297:
+	for((var) = STAILQ_FIRST((head));				\

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#483: FILE: lib/eal/include/rte_queue.h:322:
+	if ((STAILQ_NEXT((elm), field) = STAILQ_NEXT((tqelm), field)) == NULL)\

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#489: FILE: lib/eal/include/rte_queue.h:328:
+	if ((STAILQ_NEXT((elm), field) = STAILQ_FIRST((head))) == NULL)	\

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#512: FILE: lib/eal/include/rte_queue.h:351:
+		QUEUE_TYPEOF(type) *curelm = STAILQ_FIRST(head);	\
 		                   ^

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#520: FILE: lib/eal/include/rte_queue.h:359:
+	if ((STAILQ_NEXT(elm, field) =					\

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#526: FILE: lib/eal/include/rte_queue.h:365:
+	if ((STAILQ_FIRST((head)) =					\

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#532: FILE: lib/eal/include/rte_queue.h:371:
+	QUEUE_TYPEOF(type) *swap_first = STAILQ_FIRST(head1);		\
 	                   ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#533: FILE: lib/eal/include/rte_queue.h:372:
+	QUEUE_TYPEOF(type) **swap_last = (head1)->stqh_last;		\
 	                   ^

WARNING:MACRO_ARG_UNUSED: Argument 'head' is not used in function-like macro
#558: FILE: lib/eal/include/rte_queue.h:397:
+#define	LIST_HEAD_INITIALIZER(head)					\
+	{ NULL }

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#579: FILE: lib/eal/include/rte_queue.h:418:
+	QUEUE_TYPEOF(type) *curelm = LIST_FIRST(head1);			      \
 	                   ^

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#581: FILE: lib/eal/include/rte_queue.h:420:
+		if ((LIST_FIRST(head1) = LIST_FIRST(head2)) != NULL) {	      \

WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#619: FILE: lib/eal/include/rte_queue.h:458:
+#define	LIST_INIT(head) do {						\
+	LIST_FIRST((head)) = NULL;					\
+} while (0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#624: FILE: lib/eal/include/rte_queue.h:463:
+	if ((LIST_NEXT((elm), field) = LIST_NEXT((listelm), field)) != NULL)\

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#639: FILE: lib/eal/include/rte_queue.h:478:
+	if ((LIST_NEXT((elm), field) = LIST_FIRST((head))) != NULL)	\

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#654: FILE: lib/eal/include/rte_queue.h:493:
+^I^ILIST_NEXT((elm), field)->field.le_prev = ^I^I\$

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#660: FILE: lib/eal/include/rte_queue.h:499:
+	QUEUE_TYPEOF(type) *swap_tmp = LIST_FIRST(head1);		\
 	                   ^

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#663: FILE: lib/eal/include/rte_queue.h:502:
+	if ((swap_tmp = LIST_FIRST((head1))) != NULL)			\

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#665: FILE: lib/eal/include/rte_queue.h:504:
+	if ((swap_tmp = LIST_FIRST((head2))) != NULL)			\

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#762: FILE: lib/eal/include/rte_queue.h:601:
+	if ((TAILQ_NEXT((elm), field) = TAILQ_NEXT((listelm), field)) != NULL)\

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#763: FILE: lib/eal/include/rte_queue.h:602:
+^I^ITAILQ_NEXT((elm), field)->field.tqe_prev = ^I^I\$

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#780: FILE: lib/eal/include/rte_queue.h:619:
+	if ((TAILQ_NEXT((elm), field) = TAILQ_FIRST((head))) != NULL)	\

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#807: FILE: lib/eal/include/rte_queue.h:646:
+    (TAILQ_EMPTY(head) ? NULL : __containerof((head)->tqh_last, QUEUE_TYPEOF(type), field.tqe_next))$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#815: FILE: lib/eal/include/rte_queue.h:654:
+    ((elm)->field.tqe_prev == &(head)->tqh_first ? NULL :^I^I\$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#816: FILE: lib/eal/include/rte_queue.h:655:
+     __containerof((elm)->field.tqe_prev, QUEUE_TYPEOF(type), field.tqe_next))$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#820: FILE: lib/eal/include/rte_queue.h:659:
+^I^ITAILQ_NEXT((elm), field)->field.tqe_prev = ^I^I\$

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#829: FILE: lib/eal/include/rte_queue.h:668:
+	QUEUE_TYPEOF(type) *swap_first = (head1)->tqh_first;		\
 	                   ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#830: FILE: lib/eal/include/rte_queue.h:669:
+	QUEUE_TYPEOF(type) **swap_last = (head1)->tqh_last;		\
 	                   ^

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#835: FILE: lib/eal/include/rte_queue.h:674:
+	if ((swap_first = (head1)->tqh_first) != NULL)			\

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#839: FILE: lib/eal/include/rte_queue.h:678:
+	if ((swap_first = (head2)->tqh_first) != NULL)			\

total: 25 errors, 15 warnings, 1549 lines checked

Previous message (by thread): |SUCCESS| pw169756 [PATCH 3/6] build: use rte_queue.h instead of sys/queue.h
Next message (by thread): |Smoke |SUCCESS| pw(169752) sid(39322) job(PER_PATCH_BUILD20196-20260918000723) [v3] examples: add Wycheproof validation app
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the test-report mailing list