|WARNING| eal: remove atomic flag operations

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/169784

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-17

# DPDK Patch Review

## Summary
This patch removes `rte_atomic_flag_test_and_set_explicit` and `rte_atomic_flag_clear_explicit` macros from `rte_stdatomic.h` that were added in 23.11 but never used. The removal is justified by portability issues and the upcoming ABI break window in 26.11.

---

## Correctness Issues

None identified. The patch is a pure removal of unused API with proper documentation.

---

## Code Style and Quality

**Info:**
The release notes formatting is clear and well-structured. The explanation of why the API was problematic (opaque type, missing load operation, type incompatibility) provides good context for users.

---

## API and Documentation Requirements

**Warning: Release notes update in wrong section**

The API removal is documented under "Removed Items" but should also have an entry in the "API Changes" section. While the release notes do have an "API Changes" section in the template, significant API removals should be noted there in addition to (or instead of) "Removed Items."

However, the documentation is comprehensive and explains:
- What was removed
- Why it was problematic (no in-tree users, portability issues)
- What to use instead (alternatives with `RTE_ATOMIC(bool)`)

**Verification needed:**

The patch states these macros had no in-tree users. This claim should be verified by searching the codebase, but that verification is outside the scope of patch review (it's a pre-submission step).

---

## Process Compliance

**Acceptable:**
The patch notes that removal is done without a deprecation notice because:
1. The API cannot be used as specified (fundamental design issue)
2. 26.11 is an ABI break release

This aligns with DPDK policy for removing fundamentally broken API during ABI break windows.

---

## Overall Assessment

The patch is well-structured with clear justification for the removal. The release notes provide adequate migration guidance. No correctness issues or style violations identified.

**Recommendation:** The patch can be accepted after verifying there are truly no in-tree users (which should have been done before submission). Consider whether the "API Changes" section should also mention this removal for completeness.