|WARNING| net/bnxt: remove VMDq support

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/169867

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-21

# DPDK Patch Review: net/bnxt: remove VMDq support

## Summary

This patch removes VMDq (Virtual Machine Device Queues) support from the bnxt PMD. The changes are primarily deletions of VMDq-specific configuration logic, pool calculation, and VLAN-to-pool mapping. Overall, the patch is **correct** with no memory safety issues or API violations detected. There are **no errors**. One minor style observation is noted below.

---

## Warnings

### 1. Local variable `rc` initialized but may be unused after refactoring

**File:** `drivers/net/bnxt/bnxt_rxq.c`  
**Function:** `bnxt_mq_rx_configure()`

The `rc` variable is initialized to `0` and conditionally set in the removed `switch` statement error path. After this patch, the function body does not modify `rc` before the single `goto err_out;` at the end (line not shown in diff, but implied by context). If `rc` is now always returned as `0` from this function, or if the `err_out` label is no longer reachable, the initialization may be dead code.

**Suggested action:**  
Verify that the `err_out` label is still reachable and that `rc` is modified somewhere in the function body (not shown in the diff). If `rc` is no longer set to a non-zero value anywhere in the function, the initialization is unnecessary.

---

## Info

### 1. Removed unused variables -- good cleanup

**File:** `drivers/net/bnxt/bnxt_ethdev.c`  
**Function:** `bnxt_dev_info_get_op()`

Variables `max_vnics`, `i`, `j`, `vpool`, and `vrxq` are removed along with the VMDq pool calculation loop. This is correct cleanup.

### 2. Removed comment explaining VFd mapping

**File:** `drivers/net/bnxt/rte_pmd_bnxt.c`  
**Function:** `rte_pmd_bnxt_set_vf_rxmode()`

The comment `/* Is this really the correct mapping?  VFd seems to think it is. */` is deleted. As noted in the commit message, the `RTE_ETH_VMDQ_ACCEPT_*` bits are standard DPDK VF-rxmode API, not VMDq-pool-specific, so removing the comment is appropriate.

### 3. Release notes and features matrix updated

The patch correctly updates `doc/guides/nics/features/bnxt.ini` (removes `VMDq = Y`) and `doc/guides/rel_notes/release_26_11.rst` (documents the removal under "Removed Items"). This satisfies the documentation requirement.

---

## No Issues Found In

- **Memory management:** No allocations, frees, or resource leaks in the modified code.
- **Error handling:** No new error paths introduced; existing error paths are simplified (removed switch-case).
- **Atomics/threading:** No shared state or synchronization changes.
- **API:** No new API; only removed internal logic.
- **Correctness:** Removed code paths are self-contained VMDq logic; no dangling references or use-after-delete issues detected.

---

## Final Recommendation

**Accept** with the suggestion to verify the `rc` variable usage in `bnxt_mq_rx_configure()` (Warning #1). If the function body outside the diff context still uses `rc` for error propagation, the initialization is correct; otherwise, consider removing it as dead code in a follow-up cleanup.