|WARNING| [2/2] net/i40e: use common AVX-512 Tx function

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/169969

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-23

# DPDK Patch Review

## PATCH 1/2: net/i40e: use common AVX2 Tx function

### Errors

None identified.

### Warnings

**Missing release notes (1 instance)**

The patch removes 118 lines of driver-specific AVX2 Tx code and replaces it with a call to a common function from `drivers/net/intel/common/`. This is a significant internal refactoring that could affect performance or behavior. While the commit message states the code paths have "identical behaviour," this change should be documented in the release notes to inform users and maintainers.

**Suggested fix**: Add a line to `doc/guides/rel_notes/release_26_XX.rst` (where XX is the appropriate release number) under a "net/i40e" section, such as:
```rst
* Replaced AVX2 Tx implementation with shared Intel common code.
```

### Info

The removal of `vtx1()`, `vtx()`, and `i40e_xmit_fixed_burst_vec_avx2()` and their replacement with `ci_xmit_fixed_burst_vec_avx2()` appears clean. The new function is called with appropriate parameters (`false` for no offloads, `CI_TAG_IN_DATA_DESC` flags). The logic flow remains the same: still respecting the `tx_rs_thresh` boundary and handling partial bursts correctly.

---

## PATCH 2/2: net/i40e: use common AVX-512 Tx function

### Errors

None identified.

### Warnings

**Missing release notes (1 instance)**

Similar to Patch 1/2, this patch removes 110 lines of AVX-512 Tx code and replaces it with a common implementation. This should also be documented in the release notes.

**Suggested fix**: Add to the same release notes section:
```rst
* Replaced AVX-512 Tx implementation with shared Intel common code.
```

Alternatively, combine both changes into a single release note entry if they will be merged together:
```rst
* Replaced AVX2 and AVX-512 Tx implementations with shared Intel common code.
```

### Info

The refactoring is consistent with Patch 1/2. The removed functions `vtx1()`, `vtx()`, and `i40e_xmit_fixed_burst_vec_avx512()` are replaced with `ci_xmit_fixed_burst_vec_avx512()` with the same parameters and logic flow.

---

## Series-Level Comments

**Code correctness**: Both patches appear correct. The replacement functions are called with appropriate parameters, and the control flow around the calls (respecting `tx_rs_thresh`, handling return values, loop continuation) is preserved.

**Style compliance**: The patches follow DPDK style. The include of `"../common/tx_vec_x86.h"` is appropriately placed after the other common includes.

**Testing recommendation**: While not a review issue per se, this refactoring should be verified with performance testing to confirm the claim of "identical behaviour" extends to performance characteristics, particularly under different packet sizes and burst sizes.

**Overall assessment**: These are clean refactoring patches that reduce code duplication. The only notable omission is the lack of release notes for changes that affect a widely-used PMD's internal implementation.