|WARNING| net/ixgbe: fix VF link status for E610

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/170045

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-27

# DPDK Patch Review

## Patch: net/ixgbe: fix VF link status for E610

### Summary
The patch fixes incorrect link speed reporting on E610 VFs by enabling mailbox API 1.6 negotiation and querying the PF for link state instead of reading the VFLINKS register.

---

## ERRORS

### 1. Missing error check on mailbox negotiation
**File:** drivers/net/intel/ixgbe/ixgbe_ethdev.c  
**Line:** 1472-1482 (ixgbevf_negotiate_api context)

The patch adds new mailbox API versions to `sup_ver[]` but does not verify that the negotiated version is actually 1.6 before calling `ixgbevf_get_pf_link_state()` on E610 VFs.

**Why it matters:** If mailbox negotiation fails or the PF only supports API < 1.6, calling `ixgbevf_get_pf_link_state()` will fail, but the code assumes it's available whenever `hw->mac.type == ixgbe_mac_E610_vf`.

**Suggested fix:**
```c
/* E610 VF reads link state from the PF over the mailbox */
if (hw->mac.type == ixgbe_mac_E610_vf) {
	/* Only use PF link state query if API 1.6+ was negotiated */
	if (hw->api_version < ixgbe_mbox_api_16) {
		ret_val = IXGBE_ERR_FEATURE_NOT_SUPPORTED;
		*speed = IXGBE_LINK_SPEED_UNKNOWN;
		mac->get_link_status = true;
	} else {
		ret_val = ixgbevf_get_pf_link_state(hw, speed, link_up);
		if (ret_val) {
			*speed = IXGBE_LINK_SPEED_UNKNOWN;
			mac->get_link_status = true;
		} else {
			mac->get_link_status = !(*link_up);
		}
	}
	goto out;
}
```

---

## WARNINGS

### 1. Missing release notes entry
The patch fixes a significant bug (wrong link speed reported to applications) but does not include a release notes update in `doc/guides/rel_notes/release_*.rst`.

**Suggested fix:** Add an entry to the "Fixed Issues" section of the current release notes:
```rst
* **net/ixgbe: Fixed E610 VF link status reporting.**

  E610 VFs now correctly report link speed by querying the PF via mailbox API 1.6
  instead of reading the unsupported VFLINKS register.
```

### 2. Potential for silent fallback on old PF
If the PF does not support API 1.6, the new code will fail with `IXGBE_ERR_FEATURE_NOT_SUPPORTED` (after adding the check above), but there is no logging to inform the user why link speed is unavailable.

**Suggested fix:** Add a one-time warning when API version mismatch prevents link state query:
```c
if (hw->api_version < ixgbe_mbox_api_16) {
	PMD_DRV_LOG(WARNING,
		"E610 VF requires mailbox API 1.6+ for accurate link state; "
		"PF supports only API %d.%d",
		hw->api_version >> 8, hw->api_version & 0xFF);
	ret_val = IXGBE_ERR_FEATURE_NOT_SUPPORTED;
	...
}
```

---

## SUMMARY

**Critical issues:** 1 Error (missing API version check before calling new mailbox operation)  
**Non-critical issues:** 2 Warnings (missing release notes, no user-visible diagnostic for API mismatch)

The patch correctly identifies the root cause (VFLINKS register not used on E610) and applies the right fix (use mailbox query), but needs to guard the new code path with an API version check to avoid calling unsupported operations when the PF is older.