|SUCCESS| [2/2] test: check SFF-8472 external Rx power calibration

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/170323

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-29

# DPDK Patch Review

## Patch 1/2: ethdev: fix SFF-8472 external Rx power calibration

### Errors

None.

### Warnings

None.

### Info

**Floating-point clamping logic could be clearer:**

The condition `if (!(rx_power > 0))` is correct for catching NaN and negative values, but the logic could be more explicit. Consider adding a comment explaining that `!(rx_power > 0)` catches both negative values and NaN (since NaN comparisons always return false).

```c
/* Clamp to uint16_t range; !(rx_power > 0) catches NaN and negatives */
if (!(rx_power > 0))
    sd->rx_power[i] = 0;
else if (rx_power >= UINT16_MAX)
    sd->rx_power[i] = UINT16_MAX;
else
    sd->rx_power[i] = rx_power;
```

**Horner's method comment:**

The implementation correctly uses Horner's method for polynomial evaluation (better numerical stability and fewer operations than the naive approach), but this optimization is not mentioned in the comment. Consider adding a note that this is Horner's form for educational value.

---

## Patch 2/2: test: check SFF-8472 external Rx power calibration

### Errors

None.

### Warnings

None.

### Info

**Helper function could have broader utility:**

The `put_be_float()` helper is only used in this test but could be useful for other SFF-8472 tests. Consider whether it should be promoted to a shared test utility if more tests will need it in the future. (This is a forward-looking suggestion, not a requirement for this patch.)

---

## Summary

Both patches are **correct** and follow DPDK coding standards. The fix properly addresses the fourth-order polynomial evaluation bug and handles floating-point edge cases correctly. The test coverage is appropriate and validates the fix.

The only suggestions are informational (clearer comments) and do not affect correctness. These patches are ready for integration.