[dpdk-dev] [PATCH v4 01/19] net/thunderx/base: add hardware API for ThunderX nicvf inbuilt NIC

Jerin Jacob jerin.jacob at caviumnetworks.com
Tue Jun 14 15:52:12 CEST 2016


On Mon, Jun 13, 2016 at 04:09:24PM +0100, Bruce Richardson wrote:
> On Mon, Jun 13, 2016 at 07:25:25PM +0530, Jerin Jacob wrote:
> > Adds hardware specific API for ThunderX nicvf inbuilt NIC device under
> > drivers/net/thunderx/nicvf/base directory.
> > 
> 
> Hi Jerin,
> 
> we are trying to move away from huge drops of shared code in a single patchfile,
> so as to make the commits smaller and then easier to review. Can you split this
> patch into e.g. 3+ smaller commits based around logical functionality. For
> example, the base code mailbox functionality in the mbox.[ch] files could be
> its own commit. Obviously, the finer-grained the breakdown the better :-), but
> I'd rather not see patches >1 kloc looking to be merged in.

Hi Bruce,

I will send the next revision with splitting drivers/net/thunderx/nicvf/base

Jerin

> 
> Regards,
> /Bruce


More information about the dev mailing list