[dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not used

Iremonger, Bernard bernard.iremonger at intel.com
Wed Apr 12 14:30:25 CEST 2017


Hi Qi,

> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Wednesday, April 12, 2017 12:43 PM
> To: Iremonger, Bernard <bernard.iremonger at intel.com>; dev at dpdk.org
> Cc: Xing, Beilei <beilei.xing at intel.com>; Lu, Wenzhuo
> <wenzhuo.lu at intel.com>; Zhang, Qi <qi.zhang at intel.com>; Iremonger,
> Bernard <bernard.iremonger at intel.com>
> Subject: RE: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not
> used
> 
> Hi Bernard:
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bernard
> Iremonger
> > Sent: Tuesday, April 11, 2017 11:01 PM
> > To: dev at dpdk.org
> > Cc: Xing, Beilei <beilei.xing at intel.com>; Lu, Wenzhuo
> > <wenzhuo.lu at intel.com>; Zhang, Qi <qi.zhang at intel.com>; Iremonger,
> > Bernard <bernard.iremonger at intel.com>
> > Subject: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not
> > used
> >
> > In rx vector mode, the QinQ VLAN tag is not stripped.
> > When hw_vlan_extend is set for QinQ ensure that rx vector mode is not
> > selected.
> >
> > Fixes: ca74903b75cf ("net/i40e: extract non-x86 specific code from
> > vector
> > driver")
> 
> Why fixes? I didn't see above commit change rx callback function if
> hw_vlan_extend == 1

Some of the QinQ functionality was introduced in 17.02, this functionality also has the same issue.
So I added a fixes line.

> >
> > Signed-off-by: Bernard Iremonger <bernard.iremonger at intel.com>
> > ---
> >  drivers/net/i40e/i40e_rxtx_vec_common.h | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h
> > b/drivers/net/i40e/i40e_rxtx_vec_common.h
> > index 952fd4b63..692096684 100644
> > --- a/drivers/net/i40e/i40e_rxtx_vec_common.h
> > +++ b/drivers/net/i40e/i40e_rxtx_vec_common.h
> > @@ -234,6 +234,10 @@
> > i40e_rx_vec_dev_conf_condition_check_default(struct rte_eth_dev
> *dev)
> >  	if (rxmode->header_split == 1)
> >  		return -1;
> >
> > +	/* no QinQ support */
> > +	if (rxmode->hw_vlan_extend == 1)
> > +		return -1;
> > +
> >  	return 0;
> >  #else
> >  	RTE_SET_USED(dev);
> > --
> > 2.11.0

Regards,

Bernard.



More information about the dev mailing list