[dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not used

Zhang, Qi Z qi.z.zhang at intel.com
Wed Apr 12 14:42:19 CEST 2017



> -----Original Message-----
> From: Iremonger, Bernard
> Sent: Wednesday, April 12, 2017 8:30 PM
> To: Zhang, Qi Z <qi.z.zhang at intel.com>; dev at dpdk.org
> Cc: Xing, Beilei <beilei.xing at intel.com>; Lu, Wenzhuo
> <wenzhuo.lu at intel.com>; Zhang, Qi <qi.zhang at intel.com>
> Subject: RE: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not used
> 
> Hi Qi,
> 
> > -----Original Message-----
> > From: Zhang, Qi Z
> > Sent: Wednesday, April 12, 2017 12:43 PM
> > To: Iremonger, Bernard <bernard.iremonger at intel.com>; dev at dpdk.org
> > Cc: Xing, Beilei <beilei.xing at intel.com>; Lu, Wenzhuo
> > <wenzhuo.lu at intel.com>; Zhang, Qi <qi.zhang at intel.com>; Iremonger,
> > Bernard <bernard.iremonger at intel.com>
> > Subject: RE: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is
> > not used
> >
> > Hi Bernard:
> >
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bernard
> > Iremonger
> > > Sent: Tuesday, April 11, 2017 11:01 PM
> > > To: dev at dpdk.org
> > > Cc: Xing, Beilei <beilei.xing at intel.com>; Lu, Wenzhuo
> > > <wenzhuo.lu at intel.com>; Zhang, Qi <qi.zhang at intel.com>; Iremonger,
> > > Bernard <bernard.iremonger at intel.com>
> > > Subject: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is
> > > not used
> > >
> > > In rx vector mode, the QinQ VLAN tag is not stripped.
> > > When hw_vlan_extend is set for QinQ ensure that rx vector mode is
> > > not selected.
> > >
> > > Fixes: ca74903b75cf ("net/i40e: extract non-x86 specific code from
> > > vector
> > > driver")
> >
> > Why fixes? I didn't see above commit change rx callback function if
> > hw_vlan_extend == 1
> 
> Some of the QinQ functionality was introduced in 17.02, this functionality also
> has the same issue.
> So I added a fixes line.

If you think this patch is a fix, you need to find the commit that introduce this issue
The commit ca74903b75cf is not the root cause of the issue, it just move the code from 
I40e_rxtx_vec.c to i40e_rxtx_vec_common.h

Regards
Qi
 



More information about the dev mailing list