[dpdk-dev] [PATCH] devtools: check stable tag in fixes

Ferruh Yigit ferruh.yigit at intel.com
Wed Jan 18 18:25:10 CET 2017

On 1/18/2017 4:41 AM, Yuanhan Liu wrote:
> On Tue, Jan 17, 2017 at 07:42:33PM +0100, Thomas Monjalon wrote:
>> 2017-01-17 18:15, Ferruh Yigit:
>>> On 1/17/2017 2:54 PM, Thomas Monjalon wrote:
>>>> The tag "Cc: stable at dpdk.org" must be set when the commit must be
>>>> backported to a stable branch.
>>>> It must be located just below the "Fixes:" tag (without blank line)
>>>> and followed by a blank line, separated from SoB and review tags below.
>>> I am OK to keep it if it will help stable tree maintenance, but I still
>>> not clear about why we need this.
>>> If a patch is a fix, it should already have "Fixes:" line, so this can
>>> be used to parse git history.
> Same answer (as I have already replied to you in another email): not all fix
> patches should be picked to stable branch. (I gave some examples below)

I was thinking all fixes will have "Cc: stable" tag, to be sure all
fixes sent to stable mail list, and you will be the picking for stable tree.

Now you are suggesting some fixes may have "Fixes:" tag but not "Cc:
stable" tag.

So this means now author/maintainer/committer will be the picking
patches for stable tree, and to show this decision, will add "Cc:
stable" to the commit log.

If author puts the "Cc: stable" tag, git send-email will ensure this
patch will be sent to stable mail list too.
But if author missed the "Cc: stable" tag, will it be enough for you if
committer adds the tag into commit log? Or should patch sent to stable
mail list too?

What is the relation between "Cc: stable" tag been in commit log and
patch been sent to stable mail list?


More information about the dev mailing list