[dpdk-dev] [PATCH] devtools: check stable tag in fixes

Yuanhan Liu yuanhan.liu at linux.intel.com
Thu Jan 19 09:05:06 CET 2017

On Wed, Jan 18, 2017 at 05:25:10PM +0000, Ferruh Yigit wrote:
> On 1/18/2017 4:41 AM, Yuanhan Liu wrote:
> > On Tue, Jan 17, 2017 at 07:42:33PM +0100, Thomas Monjalon wrote:
> >> 2017-01-17 18:15, Ferruh Yigit:
> >>> On 1/17/2017 2:54 PM, Thomas Monjalon wrote:
> >>>> The tag "Cc: stable at dpdk.org" must be set when the commit must be
> >>>> backported to a stable branch.
> >>>>
> >>>> It must be located just below the "Fixes:" tag (without blank line)
> >>>> and followed by a blank line, separated from SoB and review tags below.
> >>>
> >>> I am OK to keep it if it will help stable tree maintenance, but I still
> >>> not clear about why we need this.
> >>>
> >>> If a patch is a fix, it should already have "Fixes:" line, so this can
> >>> be used to parse git history.
> > 
> > Same answer (as I have already replied to you in another email): not all fix
> > patches should be picked to stable branch. (I gave some examples below)
> I was thinking all fixes will have "Cc: stable" tag, to be sure all
> fixes sent to stable mail list, and you will be the picking for stable tree.
> Now you are suggesting some fixes may have "Fixes:" tag but not "Cc:
> stable" tag.
> So this means now author/maintainer/committer will be the picking
> patches for stable tree, and to show this decision, will add "Cc:
> stable" to the commit log.
> If author puts the "Cc: stable" tag, git send-email will ensure this
> patch will be sent to stable mail list too.
> But if author missed the "Cc: stable" tag, will it be enough for you if
> committer adds the tag into commit log? Or should patch sent to stable
> mail list too?

Yes, that'd be enough. I will write a short script to monitor the
official DPDK git tree regularly (say weekly), to see whether there
are any new candidates (those with 'cc: stable' tag) for stable
releases or not. If so, I will pick them to stable.

> What is the relation between "Cc: stable" tag been in commit log and
> patch been sent to stable mail list?

Not too much. The stable mailing list provides a place for further
discussion on stable patches:

- A notification will be sent to the stable mailing list when a patch
  is chosen as a candidate for a stable release. People can shout out
  if he thinks some patches should not have been picked for a stable

- people can also jump out to say, "hey, seems you forgot commit xxx,
  which is a good have for stable release".


More information about the dev mailing list