[dpdk-dev] [PATCHv6 00/33] NXP DPAA2 PMD

Ferruh Yigit ferruh.yigit at intel.com
Tue Jan 24 12:25:04 CET 2017


On 1/23/2017 5:58 PM, Ferruh Yigit wrote:
> On 1/23/2017 11:59 AM, Hemant Agrawal wrote:
> <...>
> 
>>
>> Hemant Agrawal (33):
>>   mk/dpaa2: add the crc support to the machine type
>>   drivers/common/dpaa2: adding qbman driver
>>   bus/fslmc: introducing fsl-mc bus driver
>>   bus/fslmc: introduce mc object functions
>>   bus/fslmc: add mc dpni object support
>>   bus/fslmc: add mc dpio object support
>>   bus/fslmc: add mc dpbp object support
>>   bus/fslmc: add mc dpseci object support
>>   eal/vfio: adding vfio utility functions in map file
>>   bus/fslmc: add vfio support
>>   bus/fslmc: scan for net and sec devices
>>   net/dpaa2: introducing NXP dpaa2 pmd driver
>>   doc: add dpaa2 nic details
>>   bus/fslmc: add debug log message support
>>   drivers/common/dpaa2: dpio portal driver
>>   drivers/pool/dpaa2: adding hw offloaded mempool
>>   drivers/common/dpaa2: dpio routine to affine to crypto threads
>>   net/dpaa2: adding eth ops to dpaa2
>>   net/dpaa2: add rss flow distribution
>>   net/dpaa2: configure mac address at init
>>   net/dpaa2: attach the buffer pool to dpni
>>   net/dpaa2: add support for l3 and l4 checksum offload
>>   net/dpaa2: add support for promiscuous mode
>>   net/dpaa2: add mtu config support
>>   net/dpaa2: add packet rx and tx support
>>   net/dpaa2: rx packet parsing and packet type support
>>   net/dpaa2: link status update
>>   net/dpaa2: basic stats support
>>   net/dpaa2: enable stashing for LS2088A devices
>>   net/dpaa2: add support for non hw buffer pool packet transmit
>>   net/dpaa2: enabling the use of physical addresses
>>   bus/fslmc: add support for dmamap to ARM SMMU
>>   drivers/common/dpaa2: frame queue based dq storage alloc
>>
> 
> devtools/check-git-log.sh gives following errors:
> 
> Wrong headline prefix:
>         bus/fslmc: add debug log message support

Some of these warnings are because of the assumption that the scope of
changed files are limited to the patch title tag.

For example, for this patch, because of the "bus/fslmc:", it is expected
that all modified files are under "drivers/bus/fslmc" folder, but this
patch modifies:
bus/fslmc/*
common/dpaa2/*
net/dpaa2/*

I can guess different dpaa2 modules (bus/common/net) has dependencies to
each other, and may not always be possible to separate them. This needs
to be investigated per patch.

But the more they are separated, easier to review / understand them. And
I am aware this is easier to say than to do it.

thanks,
ferruh


>         drivers/common/dpaa2: dpio portal driver

Or this one, scope is "drivers/common/dpaa2", but all the modifies files
are under "/drivers/bus/*".


>         drivers/common/dpaa2: dpio routine to affine to crypto threads
>         net/dpaa2: adding eth ops to dpaa2
>         net/dpaa2: attach the buffer pool to dpni
>         net/dpaa2: add support for l3 and l4 checksum offload
>         net/dpaa2: add mtu config support
>         net/dpaa2: add packet rx and tx support
>         net/dpaa2: enabling the use of physical addresses
>         bus/fslmc: add support for dmamap to ARM SMMU
>         drivers/common/dpaa2: frame queue based dq storage alloc
> Wrong headline lowercase:
>         net/dpaa2: introducing NXP dpaa2 pmd driver
>         doc: add dpaa2 nic details
>         drivers/pool/dpaa2: adding hw offloaded mempool
>         net/dpaa2: add rss flow distribution
>         net/dpaa2: configure mac address at init
>         net/dpaa2: add support for l3 and l4 checksum offload
>         net/dpaa2: add mtu config support
>         net/dpaa2: add packet rx and tx support
>         net/dpaa2: rx packet parsing and packet type support
>         net/dpaa2: add support for non hw buffer pool packet transmit
> Headline too long:
>         drivers/common/dpaa2: dpio routine to affine to crypto threads
>         net/dpaa2: add support for non hw buffer pool packet transmit
> 
> <...>
> 
> 
> 



More information about the dev mailing list