[dpdk-dev] [PATCH v4 25/41] net/dpaa: add support for Tx and Rx queue setup

[Ferruh Yigit]

On 9/9/2017 12:21 PM, Shreyansh Jain wrote:
> Signed-off-by: Hemant Agrawal <hemant.agrawal at nxp.com>
> Signed-off-by: Shreyansh Jain <shreyansh.jain at nxp.com>

<...>

> +
> +/* Handle all mbufs on an external pool (non-dpaa2) */

minor typo, but is intention dpaa ?

> +static inline uint16_t
> +tx_on_external_pool(struct qman_fq *txq, struct rte_mbuf *mbuf,
> +		    struct qm_fd *fd_arr)
> +{

<...>

> @@ -185,6 +185,7 @@ endif # CONFIG_RTE_LIBRTE_DPAA2_PMD
>  
>  ifeq ($(CONFIG_RTE_LIBRTE_DPAA_PMD),y)
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA_PMD)       += -lrte_bus_dpaa
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA_PMD)       += -lrte_mempool_dpaa

This should go to patch that introduces mempool.

>  endif
>  
>  endif # !CONFIG_RTE_BUILD_SHARED_LIBS
>