[dpdk-dev] [PATCH v4 25/41] net/dpaa: add support for Tx and Rx queue setup

Shreyansh Jain shreyansh.jain at nxp.com
Thu Sep 21 15:00:51 CEST 2017


On Monday 18 September 2017 08:25 PM, Ferruh Yigit wrote:
> On 9/9/2017 12:21 PM, Shreyansh Jain wrote:
>> Signed-off-by: Hemant Agrawal <hemant.agrawal at nxp.com>
>> Signed-off-by: Shreyansh Jain <shreyansh.jain at nxp.com>
> 
> <...>
> 
>> +
>> +/* Handle all mbufs on an external pool (non-dpaa2) */
> 
> minor typo, but is intention dpaa ?

Yes, this is 'dpaa'.

> 
>> +static inline uint16_t
>> +tx_on_external_pool(struct qman_fq *txq, struct rte_mbuf *mbuf,
>> +		    struct qm_fd *fd_arr)
>> +{
> 
> <...>
> 
>> @@ -185,6 +185,7 @@ endif # CONFIG_RTE_LIBRTE_DPAA2_PMD
>>   
>>   ifeq ($(CONFIG_RTE_LIBRTE_DPAA_PMD),y)
>>   _LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA_PMD)       += -lrte_bus_dpaa
>> +_LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA_PMD)       += -lrte_mempool_dpaa
> 
> This should go to patch that introduces mempool.

My patch splits are not effective it seems. Third issue of incorrect 
introduction of patch that you have pointed out. I will fix this.

> 
>>   endif
>>   
>>   endif # !CONFIG_RTE_BUILD_SHARED_LIBS
>>
> 
> 



More information about the dev mailing list