[dpdk-dev] [PATCH] app/testpmd: support bitmask for RSS and FDIR

[Xing, Beilei]

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas at monjalon.net]
> Sent: Monday, August 6, 2018 5:31 PM
> To: Xing, Beilei <beilei.xing at intel.com>
> Cc: dev at dpdk.org; Lu, Wenzhuo <wenzhuo.lu at intel.com>; Wu, Jingjing
> <jingjing.wu at intel.com>
> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support bitmask for RSS and
> FDIR
> 
> 06/08/2018 07:45, Beilei Xing:
> > This patch adds bitmask support for RSS, FDIR and FDIR flexible
> > payload.
> >
> > Signed-off-by: Beilei Xing <beilei.xing at intel.com>
> 
> Flow director API is deprecated for almost 2 years:
> 	http://git.dpdk.org/dpdk/commit/?id=7fdcde6
> We asked several times to stop using it in i40e.
> It has not been listened.
> We have even accepted a workaround in flow_filtering example for i40e:
> 	http://git.dpdk.org/dpdk/commit/?id=9a93446
> We need to stop and move all to a common rte_flow API.
> 
> As a consequence, I will be against this patch.
> 

It's not for deprecated flow director API, it's mainly for i40e private API rte_pmd_i40e_inset_set.
This patch is an extend of:
	https://patches.dpdk.org/patch/33031/

Thanks,
Beilei