[dpdk-dev] [PATCH] app/testpmd: support bitmask for RSS and FDIR

[Thomas Monjalon]

10/08/2018 04:31, Xing, Beilei:
> Hi Thomas,
> 
> From: Thomas Monjalon [mailto:thomas at monjalon.net]
> > 06/08/2018 07:45, Beilei Xing:
> > > This patch adds bitmask support for RSS, FDIR and FDIR flexible
> > > payload.
> > >
> > > Signed-off-by: Beilei Xing <beilei.xing at intel.com>
> > 
> > Flow director API is deprecated for almost 2 years:
> > 	http://git.dpdk.org/dpdk/commit/?id=7fdcde6
> > We asked several times to stop using it in i40e.
> > It has not been listened.
> > We have even accepted a workaround in flow_filtering example for i40e:
> > 	http://git.dpdk.org/dpdk/commit/?id=9a93446
> > We need to stop and move all to a common rte_flow API.
> > 
> > As a consequence, I will be against this patch.
> > 
> 
> It's not for deprecated flow director API, it's mainly for i40e private API rte_pmd_i40e_inset_set.
> This patch is an extend of:
> 	https://patches.dpdk.org/patch/33031/

It is a private API for flow director.
I feel you play with me, it's worst.