[dpdk-dev] [RFC] net/tap: add queues when attaching from secondary process

[Raslan Darawsheh]

Hi Keith, 
Yes you are right about that,
This is exactly the case and I'll need to provide a V2 for this with the kernel mapping.

Kindest regards,
Raslan Darawsheh

-----Original Message-----
From: Wiles, Keith [mailto:keith.wiles at intel.com] 
Sent: Tuesday, June 12, 2018 3:46 PM
To: Raslan Darawsheh <rasland at mellanox.com>
Cc: Thomas Monjalon <thomas at monjalon.net>; dev at dpdk.org
Subject: Re: [dpdk-dev] [RFC] net/tap: add queues when attaching from secondary process



> On Jun 7, 2018, at 6:24 PM, Raslan Darawsheh <rasland at mellanox.com> wrote:
> 
> Hi,
> 
> As you know that currently TAP pmd support attaching a secondary process to a primary process. 
> But, it's still lacking the ability to do Rx/Tx burst since it's 
> lacking the necessary fds for RX/TX queues, And the setting of Rx/Tx burst function.
> 
> This patch the main purpose is to exchange the fds between the 
> processes throw the IPC massages And to set the Rx/Tx functions for the secondary.
> 
> I hope I explained it properly, please let me know if you still didn't get it. 


I see the code sending the FD’s of primary and secondary to each other and the code looks fine. The problem I see is what I asked before in the comments below, which is the FDs on one process can not be used on another process without the kernel converting the FD for the given process. Is this the case here or not?

https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fstackoverflow.com%2Fquestions%2F8037746%2Fis-there-an-easier-way-to-share-file-descriptors-between-unrelated-processes-on&data=02%7C01%7Crasland%40mellanox.com%7C6356c8b95d8042516c1108d5d0628740%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636644043986930914&sdata=nX7%2FhXRDKrccz%2BVDUyZ%2BwB088r4R9KEQGeoZ0i2CJZk%3D&reserved=0


Regards,
Keith