[dpdk-dev] [PATCH v5 1/6] app/testpmd: fix ports list after removing several at once
thomas at monjalon.net
Thu Oct 18 16:21:28 CEST 2018
18/10/2018 13:41, Iremonger, Bernard:
> Hi Thomas
> From: Thomas Monjalon [mailto:thomas at monjalon.net]
> > 18/10/2018 12:40, Iremonger, Bernard:
> > > From: Thomas Monjalon [mailto:thomas at monjalon.net]
> > > >
> > > > From: Wisam Jaddo <wisamm at mellanox.com>
> > > >
> > > > When detaching a port, the full rte_device is removed.
> > > > If the rte_device was hosting several ports, the testpmd list of
> > > > ports must be updated for multiple removals.
> > >
> > > ./devtools/check-git-log.sh -1
> > > Missing 'Fixes' tag:
> > > app/testpmd: fix ports list after removing several at once
> > I think it is OK.
> > It is fixing a case which was not tested before.
> > And we don't really need to backport it.
> If "fix" is removed from the commit message then the fixes line will not be needed.
> However if it is a real fix, then I think fixes line should be added .
I know, I am the one implementing this check :-)
If I add a Fixes: line, it will warn about a lack of Cc:stable.
But we don't need to backport this.
That's why I think we can ignore this warning.
Reminder: it is just warning, not a mandatory requirement.
More information about the dev