[dpdk-dev] [PATCH v5 1/6] app/testpmd: fix ports list after removing several at once
bernard.iremonger at intel.com
Thu Oct 18 18:42:48 CEST 2018
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas at monjalon.net]
> Sent: Thursday, October 18, 2018 3:21 PM
> To: Iremonger, Bernard <bernard.iremonger at intel.com>
> Cc: dev at dpdk.org; Yigit, Ferruh <ferruh.yigit at intel.com>;
> arybchenko at solarflare.com; ophirmu at mellanox.com;
> rahul.lakkireddy at chelsio.com; Wisam Jaddo <wisamm at mellanox.com>
> Subject: Re: [dpdk-dev] [PATCH v5 1/6] app/testpmd: fix ports list after
> removing several at once
> 18/10/2018 13:41, Iremonger, Bernard:
> > Hi Thomas
> > From: Thomas Monjalon [mailto:thomas at monjalon.net]
> > > 18/10/2018 12:40, Iremonger, Bernard:
> > > > From: Thomas Monjalon [mailto:thomas at monjalon.net]
> > > > >
> > > > > From: Wisam Jaddo <wisamm at mellanox.com>
> > > > >
> > > > > When detaching a port, the full rte_device is removed.
> > > > > If the rte_device was hosting several ports, the testpmd list of
> > > > > ports must be updated for multiple removals.
> > > >
> > > > ./devtools/check-git-log.sh -1
> > > > Missing 'Fixes' tag:
> > > > app/testpmd: fix ports list after removing several at once
> > >
> > > I think it is OK.
> > > It is fixing a case which was not tested before.
> > > And we don't really need to backport it.
> > If "fix" is removed from the commit message then the fixes line will not be
> > However if it is a real fix, then I think fixes line should be added .
> I know, I am the one implementing this check :-) If I add a Fixes: line, it will warn
> about a lack of Cc:stable.
> But we don't need to backport this.
> That's why I think we can ignore this warning.
> Reminder: it is just warning, not a mandatory requirement.
As this does not seem to be a normal "fix", how about replacing "fix" with something like "update", then there will be no warning to ignore.
Better not have warnings.
More information about the dev