[dpdk-dev] [PATCH] vdev: free reply.msgs memory for secondary process

Thomas Monjalon thomas at monjalon.net
Thu Oct 25 09:28:13 CEST 2018


27/09/2018 15:28, Ferruh Yigit:
> On 9/21/2018 5:25 PM, Paul Luse wrote:
> > From: paul luse <paul.e.luse at intel.com>
> > 
> > This patch fixes an issue caught with ASAN where a vdev_scan()
> > to a secondary bus was failing to free some memory.
> > 
> > Signed-off-by: paul luse <paul.e.luse at intel.com>
> 
> (carry from Anatoly's ack from other thread)
> Acked-by: Anatoly Burakov <anatoly.burakov at intel.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit at intel.com>

Adding Fixes: cdb068f031c6 ("bus/vdev: scan by multi-process channel")
Cc: stable at dpdk.org

> @Anatoly, what do you think about:
>  diff --git a/lib/librte_eal/common/include/rte_eal.h
> b/lib/librte_eal/common/include/rte_eal.h
>  index e114dcbdc..e1a554f5a 100644
>  --- a/lib/librte_eal/common/include/rte_eal.h
>  +++ b/lib/librte_eal/common/include/rte_eal.h
>  @@ -309,7 +309,7 @@ rte_mp_sendmsg(struct rte_mp_msg *msg);
>    * This function sends a request message to the peer process, and will
>    * block until receiving reply message from the peer process.
>    *
>  - * @note The caller is responsible to free reply->replies.
>  + * @note The caller is responsible to free reply->msgs.
>    *
>    * @param req
>    *   The req argument contains the customized request message.

Adding this change to the commit.

Fixes: 783b6e54971d ("eal: add synchronous multi-process communication")

All applied, thanks




More information about the dev mailing list