[dpdk-dev] [PATCH] devtools: check wrong svg include in patches

Thomas Monjalon thomas at monjalon.net
Wed Oct 31 12:05:48 CET 2018


Including svg files with the svg extension is a common mistake:
	.. figure:: example.svg
must be
	.. figure:: example.*
So it will work also when building pdf doc with figures converted
to png files.

A check is added in checkpatches.sh.

Signed-off-by: Thomas Monjalon <thomas at monjalon.net>

PS: it seems this check is not working. Arnon, I need your help please.
Cc: Arnon Warshavsky <arnon at qwilt.com>
---
 devtools/checkpatches.sh | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index bf3114f95..e69b5bc34 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -50,6 +50,12 @@ check_forbidden_additions() {
 		-v EXPRESSIONS="rte_panic\\\( rte_exit\\\(" \
 		-v RET_ON_FAIL=1 \
 		-f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk -
+	# svg figures must be included with wildcard extension
+	# because of png conversion for pdf docs
+	awk -v FOLDERS='doc' \
+		-v EXPRESSIONS=':: *[^ ]*\\.svg' \
+		-v RET_ON_FAIL=1 \
+		-f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk -
 }
 
 number=0
-- 
2.19.0



More information about the dev mailing list