[dpdk-dev] [PATCH v2] usertools: dpdk-telemetry-client.py run into looping status
thomas at monjalon.net
Thu Aug 8 09:17:19 CEST 2019
07/08/2019 15:04, Andrius Sirvys:
> The ast.literal_eval() was used incorrectly and wouldn't properly
> retrieve the user option. Was causing the options to keep being listed
> in a loop. Removed and replaced with raw_input() being cast to an int.
> Works as expected now.
You mean you added "ast.literal_eval()" without testing it?
Kevin, that's not the first time I ask,
who is testing this telemetry stuff?
I have the bad feeling this is a toy,
and you send random untested patches for it.
How I can know this patch is seriously tested enough
before merging it at the last minute in 19.08?
> Fixes: 53f293c9a783 ("usertools: replace unsafe input function")
> Cc: andrius.sirvys at intel.com
> Signed-off-by: Andrius Sirvys <andrius.sirvys at intel.com>
> v2: Removed unnecessary comments
Please keep all versions in the same email thread by using --in-reply-to
> - raw_input # Python 2
> + raw_input # Python 2
> except NameError:
> - raw_input = input # Python 3
> + raw_input = input # Python 3
Why changing this indentation?
More information about the dev