[dpdk-dev] [PATCH v3] usertools: fix input handling in telemetry script
Andrius Sirvys
andrius.sirvys at intel.com
Thu Aug 8 16:37:52 CEST 2019
This commit removes the unnecesarry ast.literal_eval() function call
from the input handling, which now relies just on raw_input() to get
its input.
Fixes: 53f293c9a783 ("usertools: replace unsafe input function")
Cc: andrius.sirvys at intel.com
Signed-off-by: Andrius Sirvys <andrius.sirvys at intel.com>
---
v2: Removed unnecessary comments
v3: Reduced scope of changes only to required Python 2 fix
Please note that the dpdk-telemetry-client.py script has a number of
issues with Python3 support. Fixing Python3 support is being deferred
to DPDK 19.11 release.
---
usertools/dpdk-telemetry-client.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-client.py
index 4b0502ff9..60fe97af7 100755
--- a/usertools/dpdk-telemetry-client.py
+++ b/usertools/dpdk-telemetry-client.py
@@ -78,7 +78,7 @@ def requestMetrics(self): # Requests metrics for given client
def repeatedlyRequestMetrics(self, sleep_time): # Recursively requests metrics for given client
print("\nPlease enter the number of times you'd like to continuously request Metrics:")
- n_requests = int(ast.literal_eval(raw_input("\n:")))
+ n_requests = int(raw_input("\n:"))
print("\033[F") #Removes the user input from screen, cleans it up
print("\033[K")
for i in range(n_requests):
@@ -99,7 +99,7 @@ def interactiveMenu(self, sleep_time): # Creates Interactive menu within the scr
print("[4] Unregister client")
try:
- self.choice = int(ast.literal_eval(raw_input("\n:")))
+ self.choice = int(raw_input("\n:"))
print("\033[F") #Removes the user input for screen, cleans it up
print("\033[K")
if self.choice == 1:
--
2.17.1
More information about the dev
mailing list