[dpdk-dev] [PATCH v2] hash: optimize signature compare by using neon intrinsic

Wang, Yipeng1 yipeng1.wang at intel.com
Wed Feb 13 21:31:54 CET 2019


Hi, Ruifeng,

I don't have an ARM Platform at hand to test but I gone through the code against a NEON instruction manual, 
and the logic looks good to me. One small comment is the coding style for switch case, I think it is more common
to leave the braces on their own lines.

Otherwise:
Acked-by: Yipeng Wang<yipeng1.wang at intel.com>


>-----Original Message-----
>From: Ruifeng Wang [mailto:ruifeng.wang at arm.com]
>Sent: Monday, February 11, 2019 11:01 PM
>To: Wang, Yipeng1 <yipeng1.wang at intel.com>; jerinj at marvell.com
>Cc: dev at dpdk.org; honnappa.nagarahalli at arm.com; gavin.hu at arm.com; nd at arm.com; Ruifeng Wang <ruifeng.wang at arm.com>
>Subject: [PATCH v2] hash: optimize signature compare by using neon intrinsic
>
>Implemented signature compare function based on neon intrinsic.
>Hash bulk lookup had 3% - 6% performance gain after optimization.
>
>Signed-off-by: Ruifeng Wang <ruifeng.wang at arm.com>
>Reviewed-by: Gavin Hu <gavin.hu at arm.com>


More information about the dev mailing list