[dpdk-dev] [PATCH v2] hash: optimize signature compare by using neon intrinsic

[Ruifeng Wang (Arm Technology China)]

Hi Yipeng,

Thanks for your review and acknowledgement.
I did think about braces on separate lines. One concern is, in this way, extra indent will be needed and 
make it hard to keep code lines within 80 characters. So I made the style compromise. 

Regards,
/Ruifeng

> -----Original Message-----
> From: Wang, Yipeng1 <yipeng1.wang at intel.com>
> Sent: Thursday, February 14, 2019 4:32
> To: Ruifeng Wang (Arm Technology China) <Ruifeng.Wang at arm.com>;
> jerinj at marvell.com
> Cc: dev at dpdk.org; Honnappa Nagarahalli
> <Honnappa.Nagarahalli at arm.com>; Gavin Hu (Arm Technology China)
> <Gavin.Hu at arm.com>; nd <nd at arm.com>
> Subject: RE: [PATCH v2] hash: optimize signature compare by using neon
> intrinsic
> 
> Hi, Ruifeng,
> 
> I don't have an ARM Platform at hand to test but I gone through the code
> against a NEON instruction manual, and the logic looks good to me. One small
> comment is the coding style for switch case, I think it is more common to
> leave the braces on their own lines.
> 
> Otherwise:
> Acked-by: Yipeng Wang<yipeng1.wang at intel.com>
> 
> 
> >-----Original Message-----
> >From: Ruifeng Wang [mailto:ruifeng.wang at arm.com]
> >Sent: Monday, February 11, 2019 11:01 PM
> >To: Wang, Yipeng1 <yipeng1.wang at intel.com>; jerinj at marvell.com
> >Cc: dev at dpdk.org; honnappa.nagarahalli at arm.com; gavin.hu at arm.com;
> >nd at arm.com; Ruifeng Wang <ruifeng.wang at arm.com>
> >Subject: [PATCH v2] hash: optimize signature compare by using neon
> >intrinsic
> >
> >Implemented signature compare function based on neon intrinsic.
> >Hash bulk lookup had 3% - 6% performance gain after optimization.
> >
> >Signed-off-by: Ruifeng Wang <ruifeng.wang at arm.com>
> >Reviewed-by: Gavin Hu <gavin.hu at arm.com>