[dpdk-dev] [PATCH v2 1/4] net/failsafe: replace local device with shared data

Gaëtan Rivet gaetan.rivet at 6wind.com
Tue Mar 5 18:40:02 CET 2019


On Tue, Mar 05, 2019 at 05:43:26PM +0100, Gaëtan Rivet wrote:
> Hello Raslan,
> 
> Sorry for the delay.
> 
> I have had a little trouble reading the patches. I think the 3 first
> should be squashed into a single one, it would be more coherent.
> 
> I think I have seen a few points where doing so would have prevented
> some unnecessary changes for example, simplifying the series. (thinking
> about at least two PORT_ID() and a few ETH() removal that might have
> been prevented, I will try to point them all to you.)
> 
> On Tue, Mar 05, 2019 at 09:52:04AM +0000, Raslan Darawsheh wrote:
> > In multiprocess context, the private structure is shared between
> > processes. The back reference from private to generic data was using
> > a pointer to a per process eth_dev. It's now changed to a reference of
> > the shared data.
> > 
> > Signed-off-by: Raslan Darawsheh <rasland at mellanox.com>
> > Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
> > ---
> >  drivers/net/failsafe/failsafe.c         |  2 +-
> >  drivers/net/failsafe/failsafe_intr.c    | 10 +++++-----
> >  drivers/net/failsafe/failsafe_ops.c     |  4 ++--
> >  drivers/net/failsafe/failsafe_private.h |  6 +++++-
> >  drivers/net/failsafe/failsafe_rxtx.c    |  4 ++--
> >  5 files changed, 15 insertions(+), 11 deletions(-)
> > 
> 
> Beside the squashing, this patch seems ok.

Okay after reading a little more closely, it does not seem interesting
to squash finaly, and it will be simpler for you to continue with your
current series, so forget about that.

-- 
Gaëtan Rivet
6WIND


More information about the dev mailing list