[dpdk-dev] [PATCH v2 1/4] net/failsafe: replace local device with shared data
thomas at monjalon.net
Tue Mar 5 18:41:12 CET 2019
05/03/2019 18:40, Gaëtan Rivet:
> On Tue, Mar 05, 2019 at 05:43:26PM +0100, Gaëtan Rivet wrote:
> > I have had a little trouble reading the patches. I think the 3 first
> > should be squashed into a single one, it would be more coherent.
> > I think I have seen a few points where doing so would have prevented
> > some unnecessary changes for example, simplifying the series. (thinking
> > about at least two PORT_ID() and a few ETH() removal that might have
> > been prevented, I will try to point them all to you.)
> > Beside the squashing, this patch seems ok.
> Okay after reading a little more closely, it does not seem interesting
> to squash finaly, and it will be simpler for you to continue with your
> current series, so forget about that.
Yes, and it's easier to track changes when split as it is.
More information about the dev