[dpdk-dev] [PATCH v4 1/4] app/testpmd: add missing newline when showing statistics

David Marchand david.marchand at redhat.com
Fri Mar 22 18:23:02 CET 2019


On Fri, Mar 22, 2019 at 6:17 PM Maxime Coquelin <maxime.coquelin at redhat.com>
wrote:

>
>
> On 3/22/19 2:37 PM, David Marchand wrote:
> > Having the standard stats and the rx burst stats on the same line gives a
> > really long line and is not consistent with the rest.
> >
> > Before:
> >    RX-packets: 3542977        TX-packets: 3542971        TX-dropped: 6
>              RX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of
> others]
> >    TX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others]
> >
> > After:
> >    RX-packets: 4629969        TX-packets: 4629969        TX-dropped: 0
> >    RX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others]
> >    TX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others]
> >
> > Fixes: af75078fece3 ("first public release")
> > Cc:stable at dpdk.org
>
> While the patch is good, I wonder whether we should backport it.
> Indeed, it might break some scripts parsing testpmd output.
>
> Any thoughts?
>

It seems unlikely, this feature is disabled by default.
But yes, I would avoid backporting it.


-- 
David Marchand


More information about the dev mailing list