[dpdk-dev] [PATCH v4 1/4] app/testpmd: add missing newline when showing statistics
arybchenko at solarflare.com
Fri Mar 22 18:31:04 CET 2019
On 22.03.2019 20:23, David Marchand wrote:
> On Fri, Mar 22, 2019 at 6:17 PM Maxime Coquelin
> <maxime.coquelin at redhat.com <mailto:maxime.coquelin at redhat.com>> wrote:
> On 3/22/19 2:37 PM, David Marchand wrote:
> > Having the standard stats and the rx burst stats on the same
> line gives a
> > really long line and is not consistent with the rest.
> > Before:
> > RX-packets: 3542977 TX-packets: 3542971 TX-dropped:
> 6 RX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts
> + 61% of others]
> > TX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of
> > After:
> > RX-packets: 4629969 TX-packets: 4629969 TX-dropped: 0
> > RX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of
> > TX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of
> > Fixes: af75078fece3 ("first public release")
> > Cc:stable at dpdk.org <mailto:Cc%3Astable at dpdk.org>
> While the patch is good, I wonder whether we should backport it.
> Indeed, it might break some scripts parsing testpmd output.
> Any thoughts?
> It seems unlikely, this feature is disabled by default.
> But yes, I would avoid backporting it.
For me it looks like a bug. That's why I think it should be backported,
but the fix is not 100% correct in fact. I'll reply directly to the patch.
More information about the dev