[dpdk-dev] [PATCH v3 4/5] net/fm10k: add flow interface and switch management

[Wang, Xiao W]

Hi,

Applying: net/fm10k: add flow interface and switch management
.git/rebase-apply/patch:915: new blank line at EOF.
+
warning: 1 line adds whitespace errors.

Besides, I see that you use two empty lines to delimit two functions in some places, please align to 1 empty line.

Please understand upstreaming may mean burden of maintenance, so let's make the big patch in better shape. 😊

Best Regards,
Xiao

> -----Original Message-----
> From: Xiaojun Liu <xiaojun.liu at silicom.co.il>
> Sent: Friday, March 20, 2020 2:59 PM
> To: Wang, Xiao W <xiao.w.wang at intel.com>; Zhang, Qi Z
> <qi.z.zhang at intel.com>; Kwan, Ngai-mint <ngai-mint.kwan at intel.com>; Keller,
> Jacob E <jacob.e.keller at intel.com>
> Cc: dev at dpdk.org; Xiaojun Liu <xiaojun.liu at silicom.co.il>
> Subject: [PATCH v3 4/5] net/fm10k: add flow interface and switch management
> 
> Add flow interface to support offload flow into HW.
> It supports parse vlan and parse mpls, all these
> data will be transferred to ffu data.
> Add switch management, includes initialization,
> port mapping, epl port link, LED controller, interrupt handler.
> It create 3 threads. One for interrupt handler, one for
> LED controller, one for statistics.
> 
> Signed-off-by: Xiaojun Liu <xiaojun.liu at silicom.co.il>
> ---
>  drivers/net/fm10k/Makefile              |    2 +
>  drivers/net/fm10k/base/fm10k_type.h     |    1 +
>  drivers/net/fm10k/switch/fm10k_flow.c   |  872 +++++++++++
>  drivers/net/fm10k/switch/fm10k_flow.h   |   26 +
>  drivers/net/fm10k/switch/fm10k_stats.c  |  128 ++
>  drivers/net/fm10k/switch/fm10k_switch.c | 2382
> +++++++++++++++++++++++++++++++
[...]