[dpdk-dev] [PATCH v3 1/5] net/fm10k: add basic functions for switch management

[Xiaojun Liu]

Hi Xiao,

Please check the source file. It not looks align in patch file because the patch add "+" for each new line.

Best regards,
Xiaojun

-----Original Message-----
From: Wang, Xiao W [mailto:xiao.w.wang at intel.com] 
Sent: Thursday, April 02, 2020 4:42 PM
To: Xiaojun Liu; Zhang, Qi Z; Kwan, Ngai-mint; Keller, Jacob E
Cc: dev at dpdk.org
Subject: RE: [PATCH v3 1/5] net/fm10k: add basic functions for switch management

Hi Xiaojun,

Just comments on the alignment issue, things like below looks not nice. If you are using vim, I recommend " set tabstop=8 " setting.

+#define FM10K_SW_BIST_CTRL_BIST_RUN_PCIE(p_)	(1ULL << (p_))
+#define FM10K_SW_BIST_CTRL_BIST_RUN_EPL		(1ULL << 9)
+#define FM10K_SW_BIST_CTRL_BIST_RUN_FABRIC	(1ULL << 10)
+#define FM10K_SW_BIST_CTRL_BIST_RUN_TUNNEL	(1ULL << 11)
+#define FM10K_SW_BIST_CTRL_BIST_RUN_BSM		(1ULL << 12)
+#define FM10K_SW_BIST_CTRL_BIST_RUN_CRM		(1ULL << 13)
+#define FM10K_SW_BIST_CTRL_BIST_RUN_FIBM	(1ULL << 14)
+#define FM10K_SW_BIST_CTRL_BIST_RUN_SBM		(1ULL << 15)

+#define FM10K_SW_SCAN_DATA_IN_SHIFT_IN		(1 << 25)
+#define FM10K_SW_SCAN_DATA_IN_SHIFT_OUT		(1 << 26)
+#define FM10K_SW_SCAN_DATA_IN_UPDATE_NODES	(1 << 27)

Check more at http://patches.dpdk.org/patch/66973/. Please take care for next version.
I'm wondering if we could have a tool for automatically check this kind of alignment issue.

Best Regards,
Xiao

> -----Original Message-----
> From: Xiaojun Liu <xiaojun.liu at silicom.co.il>
> Sent: Friday, March 20, 2020 2:59 PM
> To: Wang, Xiao W <xiao.w.wang at intel.com>; Zhang, Qi Z
> <qi.z.zhang at intel.com>; Kwan, Ngai-mint <ngai-mint.kwan at intel.com>; Keller,
> Jacob E <jacob.e.keller at intel.com>
> Cc: dev at dpdk.org; Xiaojun Liu <xiaojun.liu at silicom.co.il>
> Subject: [PATCH v3 1/5] net/fm10k: add basic functions for switch management
> 
> Add I2C to control the inside LED and PHY.
> All the operations of I2C are using fm10k I2C register.
> Add SBUS to communicate with spico(micro code in serdes)
> by using fm10k SBUS register. This is like I2C operations.
> Add registers defination, which include all the registers
> will be used in the driver. Add switch management log API.
> Add switch management structures. Modify Makefile to add
> new files building. Add CONFIG_RTE_FM10K_MANAGEMENT=n
> in config/common_linux.
> 
> Signed-off-by: Xiaojun Liu <xiaojun.liu at silicom.co.il>
> ---
>  config/common_linux                     |    5 +
>  drivers/net/fm10k/Makefile              |   11 +
>  drivers/net/fm10k/switch/fm10k_debug.h  |   19 +
>  drivers/net/fm10k/switch/fm10k_i2c.c    |  309 +++++
>  drivers/net/fm10k/switch/fm10k_i2c.h    |   55 +
>  drivers/net/fm10k/switch/fm10k_regs.h   | 2302
> +++++++++++++++++++++++++++++++
>  drivers/net/fm10k/switch/fm10k_sbus.c   |  291 ++++
>  drivers/net/fm10k/switch/fm10k_sbus.h   |   40 +
>  drivers/net/fm10k/switch/fm10k_switch.h |  335 +++++
>  9 files changed, 3367 insertions(+)
>  create mode 100644 drivers/net/fm10k/switch/fm10k_debug.h
>  create mode 100644 drivers/net/fm10k/switch/fm10k_i2c.c
>  create mode 100644 drivers/net/fm10k/switch/fm10k_i2c.h
>  create mode 100644 drivers/net/fm10k/switch/fm10k_regs.h
>  create mode 100644 drivers/net/fm10k/switch/fm10k_sbus.c
>  create mode 100644 drivers/net/fm10k/switch/fm10k_sbus.h
>  create mode 100644 drivers/net/fm10k/switch/fm10k_switch.h
> 
> diff --git a/config/common_linux b/config/common_linux
> index 8168106..6e62b99 100644
> --- a/config/common_linux
> +++ b/config/common_linux
> @@ -66,3 +66,8 @@ CONFIG_RTE_LIBRTE_HINIC_PMD=y
>  # Hisilicon HNS3 PMD driver
>  #
>  CONFIG_RTE_LIBRTE_HNS3_PMD=y
> +
[...]