[dpdk-dev] [[PATCH v3 3/4] pdump: convert timestamp to nanoseconds on Rx path

Pattan, Reshma reshma.pattan at intel.com
Wed Sep 2 17:41:10 CEST 2020



> -----Original Message-----
> +			rte_eth_read_clock(port, &start_cycles);
> +			rte_eth_get_clock_freq(port, &hz);

Do you need to check return value of these calls to  handle -ENOTSUP? And avoid timestamping marking.
If -ENOTSUP, then hz value is 0 and using hz in function pdump_ts_to_ns() might be illegal.


> +			gettimeofday(&now, NULL);

Same here, need to handle return value carefully?

Thanks,
Reshma


More information about the dev mailing list