[dpdk-dev] [PATCH] cryptodev: remove crypto list end enumerators

[Kusztal, ArkadiuszX]

> -----Original Message-----
> From: Akhil Goyal <akhil.goyal at nxp.com>
> Sent: piątek, 11 września 2020 08:10
> To: Kusztal, ArkadiuszX <arkadiuszx.kusztal at intel.com>; dev at dpdk.org
> Cc: Trahe, Fiona <fiona.trahe at intel.com>
> Subject: RE: [PATCH] cryptodev: remove crypto list end enumerators
> 
> Hi Arek,
> >
> > HI Akhil,
> >
> > > > This patch removes enumerators RTE_CRYPTO_CIPHER_LIST_END,
> > > > RTE_CRYPTO_AUTH_LIST_END, RTE_CRYPTO_AEAD_LIST_END to prevent
> > > some
> > > > problems that may arise when adding new crypto algorithms.
> > > >
> > > > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal at intel.com>
> > > > ---
> > >
> > > There is a deprecation notice to remove these enums.
> > > You should remove that.
> > > Please have a single series for removal of all LIST END including
> > > the Asym
> > crypto.
> >
> > Reason that I have removed LIST_ENDs separately from symmetric and
> > asymmetric is that asymmetric API Is experimental so it did not need
> > notice, but if really needed I can combine it into one patch in v2.
> >
> I was talking about a series of patches. Different patches in a series.
Ah, I got it now, no problem.
> 
> > >
> > > And I can see that these **LIST_END are getting used in some of the
> > > crypto PMDs.
> > > Please remove all those references and cc changes to the respective
> > > PMD maintainer.
> >
> > I have informed "off the list" maintainers of PMDs that are using
> > LIST_ENDS about this patch, so they should be sending patches soon,
> > but if needed I can do it too in v2.
> >
> You can add them in your v2 and cc maintainers.