[dpdk-kmods] windows/netuio: fix bar parsing

Kadam, Pallavi pallavi.kadam at intel.com
Fri Aug 12 00:21:14 CEST 2022


On 8/9/2022 2:15 AM, Dmitry Kozlyuk wrote:
> 2022-08-08 17:33 (UTC-0700), Kadam, Pallavi:
> [...]
>>> Hi Pallavi,
>>>
>>> In the first place, it was wrong to always test `prev_bar & PCI_TYPE_64BIT`
>>> because only the first BAR slot of a 64-bit BAR contains flags.
>>> The current code has a state to track (curr_bar, prev_bar),
>>> and the fix is complicating it even more without solving the root cause.
>>> I suggest a simpler fix (not tested!)
>>> that eliminates both the incorrectness and the state to maintain:
>> Thank you. This change works for us.
>>
>> Please let me know if you would like to submit this change as a new patch or if I should include it as a v2 of this same patch.
> Please send v2.
> You can include my Signed-off-by.
> You might also update the commit message and capitalize "BAR" in the title.

Thanks, Dmitry. Have sent v2.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mails.dpdk.org/archives/dev/attachments/20220811/fa8b0a89/attachment-0001.htm>


More information about the dev mailing list