[PATCH 1/1] net/ena: restructure the llq policy user setting

[Brandes, Shai]

Sure, thanks!

בתאריך 5 ביולי 2024 20:32,‏ Ferruh Yigit <ferruh.yigit at amd.com> כתב:
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.



On 6/6/2024 2:33 PM, shaibran at amazon.com wrote:
> From: Shai Brandes <shaibran at amazon.com>
>
> Replaced `enable_llq`, `normal_llq_hdr` and `large_llq_hdr`
> devargs with a new shared devarg named `llq_policy` that
> implements the same logic and accepts the following values:
> 0 - Disable LLQ.
>     Use with extreme caution as it leads to a huge performance
>     degradation on AWS instances from 6th generation onwards.
> 1 - Accept device recommended LLQ policy (Default).
>     Device can recommend normal or large LLQ policy.
> 2 - Enforce normal LLQ policy.
> 3 - Enforce large LLQ policy.
>     Required for packets with header that exceed 96 bytes on
>     AWS instances prior to 5th generation.
>
> Signed-off-by: Shai Brandes <shaibran at amazon.com>
> Reviewed-by: Amit Bernstein <amitbern at amazon.com>
>

Hi Shai,

This patch changes device parameters and impacts end user.
Although this is not part of ABI policy, and we don't have an explicit
policy around it, but since it may impact end user experience, would you
be OK to postpone this patch to v24.11 release, where ABI break is planned?



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mails.dpdk.org/archives/dev/attachments/20240706/fecd23d6/attachment.htm>