[PATCH v1 1/2] net/e1000: better clock synchronization workaround

Burakov, Anatoly anatoly.burakov at intel.com
Thu Jun 12 13:16:26 CEST 2025


On 6/9/2025 6:23 PM, Stephen Hemminger wrote:
> On Mon,  9 Jun 2025 11:16:41 +0100
> Anatoly Burakov <anatoly.burakov at intel.com> wrote:
> 
>> +	ret_val = hw->phy.ops.write_reg_locked(hw, E1000_PHY_TIMEOUTS_REG,
>> +					       phy_timeout);
>> +
>> +	return ret_val;
> 
> Why use temporary value (ret_val) and not just a return statement?
> 
> 	return hw->phy.ops.write_reg_locked(hw, E1000_PHY_TIMEOUTS_REG, phy_timeout);

I agree with you, but this is not our code, so we can't modify it too 
much to avoid maintaining huge deltas with the base code.

-- 
Thanks,
Anatoly


More information about the dev mailing list